Skip to content

Conversation

@kwk
Copy link
Collaborator

@kwk kwk commented Oct 7, 2025

Merge only once this is green for the architectures that support MLIR: https://copr.fedorainfracloud.org/coprs/g/fedora-llvm-team/python-nanobind/build/9666166/

@kwk kwk marked this pull request as ready for review October 7, 2025 20:13
@kwk kwk requested review from Copilot and tbaederr October 8, 2025 10:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the python-nanobind copr repository to the build-time repositories for LLVM snapshot builds. The change enables the build system to access the python-nanobind package during compilation, which is needed for MLIR support on compatible architectures.

  • Adds "copr://@fedora-llvm-team/python-nanobind/" to the additional_copr_buildtime_repos list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tuliom
Copy link
Collaborator

tuliom commented Oct 8, 2025

I don't think this is needed right now because we are not building MLIR on branched Fedora.
AFAIU, we're waiting for opinions on the options we have.
Or what am I missing?

@kwk
Copy link
Collaborator Author

kwk commented Oct 8, 2025

I don't think this is needed right now because we are not building MLIR on branched Fedora. AFAIU, we're waiting for opinions on the options we have. Or what am I missing?

What about people "depending" on snapshots for bleeding edge work? They most likely don't run rawhide and so they will never get MLIR, right?

@tuliom
Copy link
Collaborator

tuliom commented Oct 8, 2025

What about people "depending" on snapshots for bleeding edge work? They most likely don't run rawhide and so they will never get MLIR, right?

Indeed. But testing more scenarios increases our burden too.
So we need to find a tradeoff between spending too much time dealing with issues in unsupported environments and being able to reuse our builds plus getting information from different environments.

With that said, we may want to ask ourselves which parts of the LLVM projects we usually reuse from the daily snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants