Skip to content

Conversation

@lsm5
Copy link

@lsm5 lsm5 commented Oct 16, 2017

Signed-off-by: Lokesh Mandvekar [email protected]

@contyk PTAL :)

README.md Outdated
| `ruby` | | | | | | [**2017-10-03**](https://mbs.fedoraproject.org/module-build-service/1/module-builds/1036) |
| `varnish` | | | | | | [**2017-07-10**](https://mbs.fedoraproject.org/module-build-service/1/module-builds/703) |
| `golang` | lsm5 | | | | | |
| `container-shared` | lsm5 | | | | | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it is good name...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm open to anything that doesn't have the word docker in it :) , since cri-o and buildah will need it too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base-container, container-platform, platform-container ????

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ignatenkobrain what's wrong w/ the name? Please let us know if you have another idea.

Thanks,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, bikeshedding about the name ;) Well, do you expect the module to be usable on its own or only together with one of the other container modules? If it needs something else, I think shared is a reasonable name and doesn't evoke the feeling that installing this module is enough to get everything you need, like the other suggested names do.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"runtime" has become a loaded term in the container space. I'd like to avoid it altogether with this module's name. I think I'm leaning towards container-tools or container-utils.

@lsm5 should buildah be included in this module as well?

Copy link
Author

@lsm5 lsm5 Oct 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrguitar @rhatdan mentioned this as a separate module in prior discussion, though I'm ok either way. buildah doesn't depend on anything in docker or cri-o so including it in container-[shared|utils|tools] should be fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomasTomecek apache-commons is named like that because it is how it is named in upstream ;)

container-tools would be better possibly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like everyone agrees with container-tools, so I'll send a new commit to reflect that, also gonna get rid of buildah module

@lsm5 lsm5 force-pushed the container-runtime branch from c85da24 to c7a4611 Compare October 18, 2017 14:45
@lsm5 lsm5 force-pushed the container-runtime branch from c7a4611 to 4e9aa1a Compare October 18, 2017 14:46
@lsm5
Copy link
Author

lsm5 commented Oct 18, 2017

@ignatenkobrain @contyk updated commit, PTAL

@TomasTomecek
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants