-
Notifications
You must be signed in to change notification settings - Fork 4
add modules for container runtimes and dependencies #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
README.md
Outdated
| | `ruby` | | | | | | [**2017-10-03**](https://mbs.fedoraproject.org/module-build-service/1/module-builds/1036) | | ||
| | `varnish` | | | | | | [**2017-07-10**](https://mbs.fedoraproject.org/module-build-service/1/module-builds/703) | | ||
| | `golang` | lsm5 | | | | | | | ||
| | `container-shared` | lsm5 | | | | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if it is good name...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm open to anything that doesn't have the word docker in it :) , since cri-o and buildah will need it too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base-container, container-platform, platform-container ????
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ignatenkobrain what's wrong w/ the name? Please let us know if you have another idea.
Thanks,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, bikeshedding about the name ;) Well, do you expect the module to be usable on its own or only together with one of the other container modules? If it needs something else, I think shared is a reasonable name and doesn't evoke the feeling that installing this module is enough to get everything you need, like the other suggested names do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"runtime" has become a loaded term in the container space. I'd like to avoid it altogether with this module's name. I think I'm leaning towards container-tools or container-utils.
@lsm5 should buildah be included in this module as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomasTomecek apache-commons is named like that because it is how it is named in upstream ;)
container-tools would be better possibly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like everyone agrees with container-tools, so I'll send a new commit to reflect that, also gonna get rid of buildah module
c85da24 to
c7a4611
Compare
Signed-off-by: Lokesh Mandvekar <[email protected]>
c7a4611 to
4e9aa1a
Compare
|
@ignatenkobrain @contyk updated commit, PTAL |
|
LGTM |
Signed-off-by: Lokesh Mandvekar [email protected]
@contyk PTAL :)