FDG 9798 Add Chart Design to the Interest Expense Topic Page #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdach
reviewed
Nov 13, 2024
src/layouts/insight/sections/interest-expense/interest-expense-chart/interest-expense-chart.tsx
Outdated
Show resolved
Hide resolved
jdach
reviewed
Nov 13, 2024
src/layouts/insight/sections/interest-expense/interest-expense-chart/interest-expense-chart.tsx
Outdated
Show resolved
Hide resolved
jdach
requested changes
Nov 13, 2024
Contributor
jdach
left a comment
jdach
left a comment
There was a problem hiding this comment.
Chart looks great! Looks like there is a missing interaction for changing the header from FYTD to Fiscal Year depending on what year is hovered. This could be included in the ticket to hook in the data if you think it makes for sense there but should just be noted in both tickets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://federal-spending-transparency.atlassian.net/browse/FDG-9798
Coverage: