Skip to content

Conversation

@ntsim99
Copy link
Contributor

@ntsim99 ntsim99 commented Dec 10, 2025

JIRA Ticket:

FDG-9315

The following are ALL required for the PR to be merged:

  • Provided testing instructions in JIRA ticket if applicable
  • Provided mocks or additional information in JIRA ticket if applicable
  • Verified cross-browser compatibility: Chrome, Safari, Firefox, Edge
  • Verified mobile/tablet/desktop/monitor responsiveness
  • Verified that this PR does not create any new accessibility issues (via Axe Chrome)
  • Verify all files are covered by at least 90% test coverage if applicable
  • Check for code quality
    + Watch out for irrelevant changes
    + Take time to understand the logic and flow; be on guard for pitfalls
    + Look at handoff between components (esp. number of props)
    + Watch out for literals (vs. variables) for css specs if applicable

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Total Line Coverage: 90.7% ✅

@ntsim99 ntsim99 marked this pull request as ready for review December 10, 2025 20:46
Copy link
Contributor

@chasls2 chasls2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@chasls2 chasls2 merged commit 2d6d878 into master Dec 11, 2025
3 checks passed
@ntsim99 ntsim99 deleted the FDG-9315 branch December 22, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants