[DEV-11765] Fix subaward zip bug #4439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use the 5-digit zip code for subawards instead of the larger form zip code.
Technical Details:
There are a few small changes grouped into this PR:
sub_pop_zip5instead ofsub_pop_zipwhen filtering the zip code on Subawards. This is a pattern we use for both Awards and Transactions, and I was unable to see a reason why we would use the longer form zip code at this time. Optionally, we could support querying the longer form zip code (and changes were initially queued up for this), but that adds extra functionality that I don't believe was intended at this time.Sub-Award IDfield. Sorting onSub-Award IDwas previously sorting on the Prime Award's value fordisplay_award_idwhich is confusing because theSub-Award IDis actually thesubaward_number. This was corrected initially for the purpose of test cases although that has since changed. But this change was left in place as it is a small bug that improves UX on the site and API.sub_pop_zip5value when thesub_pop_zipvalue is not 5 or 9 characters. This was causing a weird UI bug where a Subaward would appear in the filter, but the zip code wouldn't show on the page because thesub_pop_zipoften has extra characters in it.Requirements for PR Merge:
Explain N/A in above checklist: