[DEV-13726] Implement File B downloads in DuckDB #4548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethstoudenmier
requested changes
Dec 10, 2025
usaspending_api/download/delta_downloads/object_class_program_activity.py
Show resolved
Hide resolved
usaspending_api/download/management/commands/generate_spark_download.py
Outdated
Show resolved
Hide resolved
usaspending_api/download/management/commands/generate_spark_download.py
Outdated
Show resolved
Hide resolved
sethstoudenmier
requested changes
Dec 11, 2025
sethstoudenmier
requested changes
Dec 12, 2025
Contributor
sethstoudenmier
left a comment
sethstoudenmier
left a comment
There was a problem hiding this comment.
Few more comments on use of CONFIG I noticed and then some questions about error handling, but mostly looking good. Still outstanding thought on if we want to include a new Dockerfile to breakout install of DuckDB.
sethstoudenmier
previously approved these changes
Dec 15, 2025
sethstoudenmier
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add DuckDB as an option for File B Custom Account downloads.
Technical Details:
DuckDB's Spark implementation doesn't implement every Spark/PySpark function so some substitutions had to be made when using DuckDB.
Requirements for PR Merge:
Explain N/A in above checklist:
No API documentation is affected by this change.