Skip to content

Conversation

@zachflanders-frb
Copy link
Contributor

@zachflanders-frb zachflanders-frb commented Dec 15, 2025

Description:

This PR splits file c downloads into award categories (assistance, contracts, and unlinked).

Technical Details:

This PR changes the concept of a download. Before a download had one file name and one dataframe. Now a download can have multiple file names and multiple dataframes. I updated the base download class to reflect this and also updated the inheriting classes where needed as well as the consuming code.

Requirements for PR Merge:

  1. Unit & integration tests updated
  2. API documentation updated (examples listed below)
    1. API Contracts
    2. API UI
    3. Comments
  3. Data validation completed (examples listed below)
    1. Does this work well with the current frontend? Or is the frontend aware of a needed change?
    2. Is performance impacted in the changes (e.g., API, pipeline, downloads, etc.)?
    3. Is the expected data returned with the expected format?
  4. Appropriate Operations ticket(s) created
  5. Jira Ticket(s)
    1. DEV-14106

Explain N/A in above checklist:

StructField("reporting_fiscal_quarter", IntegerType()),
StructField("reporting_fiscal_year", IntegerType()),
StructField("quarter_format_flag", BooleanType()),
StructField("is_fpds", BooleanType(), nullable=True),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nullable=True is the default, but it doesn't hurt to be explicit here since this is different than transaction_search

@zachflanders-frb zachflanders-frb merged commit 35a6be3 into qat Dec 16, 2025
18 checks passed
@zachflanders-frb zachflanders-frb deleted the ftr/dev-14106-file-c-download-award-categories branch December 16, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants