[DEV-14487] Additional changes for transition of initial_report_date and last_modified_date to timestamp#4594
Open
sethstoudenmier wants to merge 3 commits intostagingfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updates additional usages of
last_modified_dateto be consistent with the change to a datetime. And updates management commands to allow copy back of a table to support swap in place.Technical Details:
Migrations were updated / created to support the swap in place. The temporary column names for the swap in place are designed to match temporary columns that will be added to the corresponding Delta tables.
A few other fields were updated to be consistent with the data they are pulled from.
Field updates:
initial_report_dateontransaction_fpdswas updated to support datetimeinitial_reportontransaction_fpdswas updated to support datetimelast_modified_dateonaward_searchwas updated to support datetimelast_modified_dateonsubaward_seachin was updated to support datetimelast_modified_dateontransaction_normalizedwas updated to support datetimeNot style check related udpates:
copy_table_metadatacommand; promotes a consistent performance across runs--additional-columnsflag is added toload_table_from_deltato support copying from Delta to Postgres the target table along with columns that aren't part of the table definition in code; useful for swap in placeRequirements for PR Merge:
Explain N/A in above checklist: