Skip to content

DEV - 14177: Remove use of DefaultProps in Spending Explorer #5035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jagu65 merged 3 commits into from
Jan 7, 2026
Merged

DEV - 14177: Remove use of DefaultProps in Spending Explorer #5035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e497212
wip
jdhfrb Jan 6, 2026
6d463c9
add in default height
jdhfrb Jan 6, 2026
f5f81cc
pr feedback changes
jdhfrb Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/js/components/explorer/ExplorerWrapperPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,15 @@ const propTypes = {
showShareIcon: PropTypes.bool
};

const defaultProps = {
showShareIcon: false
};

require('pages/explorer/explorerPage.scss');

const slug = 'explorer';
const emailSubject = 'USAspending.gov Federal Spending Explorer';

const ExplorerWrapperPage = (props) => {
const ExplorerWrapperPage = ({
showShareIcon = false,
children
}) => {
const dispatch = useDispatch();
const handleShareDispatch = (url) => {
dispatch(showModal(url));
Expand All @@ -45,21 +44,20 @@ const ExplorerWrapperPage = (props) => {
classNames="usa-da-explorer-page"
title="Spending Explorer"
metaTagProps={explorerPageMetaTags}
toolBarComponents={props.showShareIcon ? [
toolBarComponents={showShareIcon ? [
<ShareIcon
onShareOptionClick={handleShare}
url={getBaseUrl(slug)} />
] : []}>
<main
id="main-content"
className="main-content">
{props.children}
{children}
</main>
</PageWrapper>
);
};

ExplorerWrapperPage.propTypes = propTypes;
ExplorerWrapperPage.defaultProps = defaultProps;

export default ExplorerWrapperPage;
10 changes: 5 additions & 5 deletions src/js/components/explorer/detail/ExplorerDetailPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Created by Kevin Li 8/16/17
*/

import React, { useState } from 'react';
import React, { useCallback, useState } from 'react';
import DetailContentContainer from 'containers/explorer/detail/DetailContentContainer';
import ExplorerWrapperPage from '../ExplorerWrapperPage';
import ExplorerTooltip from './visualization/ExplorerTooltip';
Expand All @@ -22,14 +22,14 @@ const ExplorerDetailPage = () => {
isAward: false
});

const showTooltipFn = (position, data) => {
const showTooltipFn = useCallback((position, data) => {
setShowTooltip(true);
setTooltip(Object.assign({}, position, data));
};
}, []);

const hideTooltipFn = () => {
const hideTooltipFn = useCallback(() => {
setShowTooltip(false);
};
}, []);

let tooltipUi = null;

Expand Down
Loading