Skip to content

Conversation

@gerrod
Copy link

@gerrod gerrod commented May 19, 2021

This is a small change to the typings for the FeedbackFish component. Using ReactNode allows null or false to be passed as a valid child (in order to disable the widget without unmounting the component).e.g -

<FeedbackFish projectId="abcde">
    {canSubmitFeedback && (
        <Button>Feedback!</Button>
    )}
</FeedbackFish>

@gerrod
Copy link
Author

gerrod commented Oct 1, 2021

@mxstbr - any chance of having a look at this PR? We have to use a hacky work-around for this in our code because of the incorrect typings :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant