Skip to content

Fix assert message error #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xiangyanglikecode wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix assert message error #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8314a7c
Fix assertion message for world_size check
Xiangyanglikecode Oct 17, 2025
42531d0
Fix assertion error message in globals.py
Xiangyanglikecode Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions yunchang/globals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def set_seq_parallel_pg(

assert (
world_size % sp_degree == 0
), f"world_size {world_size} % sp_degree {sp_ulysses_degree} == 0"
), f"world_size {world_size} % sp_degree {sp_degree} != 0"

num_ulysses_pgs = sp_ring_degree # world_size // sp_ulysses_degree
num_ring_pgs = sp_ulysses_degree # world_size // sp_ring_degree
Expand Down Expand Up @@ -132,4 +132,4 @@ def get_cuda_arch():
import torch_npu
HAS_NPU = True
except ImportError:
HAS_NPU = False
HAS_NPU = False