Enable tree fields in .values() and .values_list() calls #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables tree fields (
tree_depth
,tree_path
,tree_ordering
, and custom tree fields) to be included in.values()
and.values_list()
calls while maintaining full backward compatibility.Problem
Previously, tree fields were excluded from
.values()
calls even when explicitly requested:Solution
Modified the
TreeCompiler.as_sql()
method to:.values()
callNew Functionality
Backward Compatibility
All existing behavior is preserved:
Implementation Details
The fix required only a 6-line change in
TreeCompiler.as_sql()
:elif self.query.values_select:
toelif self.query.values_select is not None:
.values()
This change works with all supported database backends (PostgreSQL, MySQL, SQLite) since it leverages the existing CTE infrastructure without modification.
Fixes #69.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.