Fix tree fields not being available after Model.objects.create() with with_tree_fields=True #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
TreeQuerySet.as_manager(with_tree_fields=True)
, tree fields (tree_depth
,tree_path
,tree_ordering
) were not available on instances returned byModel.objects.create()
, forcing users to perform an additional database query to access these fields.Problem
Solution
Now tree fields are automatically available after
create()
whenwith_tree_fields=True
:Implementation
TreeManager.create()
: Re-queries the created instance with tree fields whenwith_tree_fields=True
TreeManager.bulk_create()
: Documents that bulk operations don't return tree fields (expected behavior for performance)Documentation
Added comprehensive documentation to
README.rst
explaining:create()
behavior with examplesbulk_create()
limitationsrefresh_from_db()
behavior and workaroundsBackward Compatibility
No breaking changes - existing code continues to work exactly as before. The fix only affects models using
with_tree_fields=True
and provides the intuitive behavior users expect.Fixes #40.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com
/usr/lib/apt/methods/https
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.