Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,6 @@ jobs:
codecov_token: ${{ secrets.CODECOV_TOKEN }}
working_directory: packages/${{ matrix.package }}
min_coverage: 100
# TODO(felangel): remove when bloc_lint v0.4.0 is released.
collect_score: ${{ matrix.package != 'bloc_lint' }}

bloc_tools_compile_checks:
needs: changes
Expand Down Expand Up @@ -385,6 +383,7 @@ jobs:
analyze_directories: lib
collect_coverage: false
collect_score: false
flutter_channel: master
working_directory: examples/${{ matrix.example }}

docs_checks:
Expand Down
10 changes: 9 additions & 1 deletion packages/bloc_lint/lib/src/linter.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import 'dart:convert';
import 'dart:io';

// Use the experimental features from the shared frontend.
// ignore: implementation_imports
import 'package:_fe_analyzer_shared/src/parser/experimental_features.dart'
show DefaultExperimentalFeatures;

// Use the parser from the shared frontend.
// ignore: implementation_imports
import 'package:_fe_analyzer_shared/src/parser/parser.dart' show Parser;
Expand Down Expand Up @@ -93,7 +98,10 @@ class Linter {
final context = LintContext._(rule: rule, document: document);
final listener = rule.create(context);
if (listener == null) continue;
Parser(listener).parseUnit(tokens);
Parser(
listener,
experimentalFeatures: const DefaultExperimentalFeatures(),
).parseUnit(tokens);
diagnostics.addAll(context.diagnostics);
}
return results;
Expand Down
3 changes: 2 additions & 1 deletion packages/bloc_lint/lib/src/rules/avoid_public_fields.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ class _Listener extends Listener {
}

@override
void endClassFields(
void endFields(
DeclarationKind kind,
Token? abstractToken,
Token? augmentToken,
Token? externalToken,
Expand Down
2 changes: 1 addition & 1 deletion packages/bloc_lint/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ environment:
sdk: ">=3.7.0 <4.0.0"

dependencies:
_fe_analyzer_shared: ">=75.0.0 <=91.0.0"
_fe_analyzer_shared: ">=93.0.0 <95.0.0"
checked_yaml: ^2.0.0
collection: ^1.0.0
glob: ^2.0.0
Expand Down