Skip to content

fix uses of XML.depth #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

fix uses of XML.depth #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ ZipArchives = "49080126-0e18-4c2a-b176-c102e4b3760c"

[compat]
Tables = "1"
XML = "0.3.4"
XML = "0.3.5"
ZipArchives = "2"
julia = "1.7"

Expand Down
2 changes: 1 addition & 1 deletion src/stream.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function Base.iterate(itr::SheetRowStreamIterator, state::Union{Nothing, SheetRo
if nrows == 0
return nothing
end
@assert XML.depth(lznode) == 1 "Malformed Worksheet \"$(ws.name)\": unexpected node depth for sheetData node: $(XML.depth(lznode))."
@assert XML.depth(lznode) == 2 "Malformed Worksheet \"$(ws.name)\": unexpected node depth for sheetData node: $(XML.depth(lznode))."
break
end

Expand Down
2 changes: 1 addition & 1 deletion src/worksheet.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function read_worksheet_dimension(xf::XLSXFile, relationship_id, name) :: Union{
while reader !== nothing # go next node
(sheet_row, state) = reader
if XML.nodetype(sheet_row) == XML.Element && XML.tag(sheet_row) == "dimension"
@assert XML.depth(sheet_row) == 1 "Malformed Worksheet \"$name\": unexpected node depth for dimension node: $(XML.depth(sheet_row))."
@assert XML.depth(sheet_row) == 2 "Malformed Worksheet \"$name\": unexpected node depth for dimension node: $(XML.depth(sheet_row))."
ref_str = XML.attributes(sheet_row)["ref"]
if is_valid_cellname(ref_str)
result = CellRange("$(ref_str):$(ref_str)")
Expand Down
Loading