-
Notifications
You must be signed in to change notification settings - Fork 61
Incremental performance #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental performance #304
Conversation
was itself fixed (as yet untested).
Separate stream interator from cache iterator
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
- Coverage 95.02% 93.54% -1.48%
==========================================
Files 15 19 +4
Lines 2009 5715 +3706
==========================================
+ Hits 1909 5346 +3437
- Misses 100 369 +269 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also add `PrecompileTools` (felipenoris#277)
and allow cells containing only spaces retain their value.
(JuliaComputing/XML.jl#43) Can now write cells containing only whitespage characters or with leading or trailing whitespace. Cannot see these things in cells read in from existing Excel files - XML removes leading whitespace even if `xml:space="preserve"` is specified. Thus a cell containing " " will be read in as missing. A cell containing " hello" will become "hello".
I've tried to work around issue 43 in XML.jl but can't do this completely. There was an issue in the handling of blank (whitespace only) strings in XLSX, too (#308), which I've tried to fix.
|
I've made a PR to XML.jl to try to fix the issue with |
Builds on everything in #298 and adds the following:
setFormatAttribute
family of functions to more than double speed.eachrow
to iterate through sheets. Indexing into the worksheet cache (where possible) is generally faster.setConditionalFormat
to pass aDict
of keyword options as discussed here to speed up compilation a little.copysheet!
function to make a copy of a worksheet in anXLSXFile
.XLSXFile.source
ofXLSXFile
s created withnewxlsx
to be located inpwd()
rather than_relocatable_data_path