Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Unreleased
----------
- Declare support for Python 3.12 and 3.13 (:issue:`150`)
- Remove support for Python 3.7 and 3.8 (:issue:`150`)
- Fix changed whitespace handling in Pygments 2.19 (:issue:`152`)

0.15.2 (2024-06-03)
-------------------
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ requires-python = ">=3.9"
dependencies = [
"sphinx>=3.2.0",
"beautifulsoup4>=4.8.1",
"pygments<2.19",
]
# Keep extras in sync with requirements manually
optional-dependencies = {ipython = ["ipython!=8.7.0"]}
Expand Down
32 changes: 17 additions & 15 deletions src/sphinx_codeautolink/extension/block.py
Original file line number Diff line number Diff line change
Expand Up @@ -371,20 +371,22 @@ def link_html(

# The builtin re doesn't support variable-width lookbehind,
# so instead we use a match groups in all pre patterns to remove the non-content.
no_dot_prere = r'(?<!<span class="o">\.</span>)()'
no_dot_pre = r'(?<!<span class="o">\.</span>)()'
# Potentially instead assert an initial closing parenthesis followed by a dot.
call_dot_prere = r'(\)</span>\s*<span class="o">\.</span>\s*)'
import_prere = (
r'((<span class="kn">import</span>\s+(<span class="p">\(</span>\s*)?)'
r'|(<span class="[op]">,</span>\s*))'
call_dot_pre = r'(\)</span>\s*<span class="o">\.</span>\s*)'
no_dot_post = r'(?!(<span class="o">\.)|(</a>))'

# Pygments 2.19 changed import whitespace highlighting so we need to support both
# with "w" class and raw whitespace for now (see #152)
whitespace = r'(<span class="w">\s*</span>)|(\s*)'
import_pre = (
rf'((<span class="kn">import</span>{whitespace}(<span class="p">\(</span>\s*)?)'
rf'|(<span class="[op]">,</span>{whitespace}))'
)
from_prere = r'(<span class="kn">from</span>\s+)'
import_post = r'(?=($)|(\s+)|(<span class="[opw]">))(?!</a>)'

no_dot_postre = r'(?!(<span class="o">\.)|(</a>))'
import_postre = (
r'(?=($)|(\s+)|(<span class="[op]">,</span>)|(<span class="p">\)))(?!</a>)'
)
from_postre = r'(?=\s*<span class="kn">import</span>)'
from_pre = rf'(<span class="kn">from</span>{whitespace})'
from_post = rf'(?={whitespace}<span class="kn">import</span>)'


def construct_name_pattern(name: Name) -> str:
Expand All @@ -395,17 +397,17 @@ def construct_name_pattern(name: Name) -> str:
[first_name_pattern.format(name=parts[0])]
+ [name_pattern.format(name=p) for p in parts[1:]]
)
return no_dot_prere + pattern + no_dot_postre
return no_dot_pre + pattern + no_dot_post
elif name.context == LinkContext.after_call:
parts = name.code_str.split(".")
pattern = period.join(
[first_name_pattern.format(name=parts[0])]
+ [name_pattern.format(name=p) for p in parts[1:]]
)
return call_dot_prere + pattern + no_dot_postre
return call_dot_pre + pattern + no_dot_post
elif name.context == LinkContext.import_from:
pattern = import_from_pattern.format(name=name.code_str)
return from_prere + pattern + from_postre
return from_pre + pattern + from_post
elif name.context == LinkContext.import_target:
pattern = import_target_pattern.format(name=name.code_str)
return import_prere + pattern + import_postre
return import_pre + pattern + import_post
Loading