Skip to content

Conversation

@felixAnhalt
Copy link
Owner

This pull request introduces a significant refactor to replace the DiffViewProvider with a new IEditingProvider abstraction across the codebase. Additionally, it adds a new fileBasedEditing setting to the global settings schema. Below are the most important changes grouped by theme:

Refactor: Transition to IEditingProvider

  • Replaced DiffViewProvider with IEditingProvider in the Task class, updating its initialization, methods, and references to use the EditingProviderFactory for creation and management. (src/core/task/Task.ts: [1] [2] [3] [4] [5] [6] [7] [8]
  • Updated all test files to replace diffViewProvider with editingProvider, ensuring consistency in mock setups and assertions. (src/core/tools/__tests__/applyDiffTool.experiment.spec.ts: [1] src/core/tools/__tests__/insertContentTool.spec.ts: [2] [3] [4] [5] [6] src/core/tools/__tests__/writeToFileTool.spec.ts: [7] [8] [9] [10] [11] [12] [13] [14] [15]
  • Refactored the applyDiffToolLegacy function to use editingProvider for operations like opening, updating, and reverting changes. (src/core/tools/applyDiffTool.ts: [1] [2]

New Feature: Global Settings Update

  • Added a new fileBasedEditing boolean property to the globalSettingsSchema and initialized it in the EVALS_SETTINGS object with a default value of false. (packages/types/src/global-settings.ts: [1] [2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants