Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive inline documentation to TypeSpec model definitions across the codebase. The documentation clarifies the purpose and structure of models used in the eInnsyn (public records access) system, covering both web-facing models (access requests, user feedback) and archive-related models (documents, meetings, cases).
Key changes:
- Enhanced model-level documentation with clear descriptions of each entity's purpose in the system
- Added inline comments for all model properties explaining their role and content
- Included English translations for Norwegian enum values to aid understanding
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| typespec/einnsyn.web.models.tsp | Added documentation for web models including access requests (Innsynskrav), saved searches (LagretSoek), and user feedback (Tilbakemelding) |
| typespec/einnsyn.arkiv.models.tsp | Added documentation for archive models covering documents (Dokumentbeskrivelse, Dokumentobjekt), organizational units (Enhet), registry entries (Journalpost), meetings (Moetemappe, Moetesak), and decisions (Vedtak) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
havtorr
approved these changes
Dec 10, 2025
havtorr
approved these changes
Dec 11, 2025
This was referenced Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.