Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates search parameters and API operations in a TypeSpec-based API definition, introducing more flexible date filtering and expanding sortable fields.
Changes:
- Adds
implicitOptionality: trueto multiple@patchdecorators across various operations - Introduces a new
timeStringscalar type supporting both absolute and relative date formats (similar to Grafana/Elasticsearch syntax) - Expands the
sortByfield with additional sorting options for search results - Adds new filter parameters for title, correspondent name, and legal basis
- Converts date filter parameters from
utcDateTime | plainDateto the newtimeStringtype - Adds new operations for managing
DokumentobjektandSkjermingresources
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| typespec/einnsyn.web.operations.tsp | Adds implicitOptionality: true to PATCH operations and expands sortBy field with 9 additional sort options |
| typespec/einnsyn.queryparameters.tsp | Introduces timeString scalar type with comprehensive date/time syntax documentation and adds new filter parameters |
| typespec/einnsyn.arkiv.operations.tsp | Updates PATCH decorator and adds new operations for document objects and screening |
Comments suppressed due to low confidence (1)
typespec/einnsyn.queryparameters.tsp:1
- The sortBy field values are not alphabetically ordered, which could make maintenance difficult. Consider ordering them alphabetically to improve readability and maintainability.
import "@typespec/http";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
havtorr
approved these changes
Jan 22, 2026
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.