Skip to content

Update search parameters#15

Merged
gne merged 2 commits intomainfrom
EIN-4789-konvertering-reindeksering-av-gamle-lagret-soek
Jan 22, 2026
Merged

Update search parameters#15
gne merged 2 commits intomainfrom
EIN-4789-konvertering-reindeksering-av-gamle-lagret-soek

Conversation

@gne
Copy link
Contributor

@gne gne commented Jan 14, 2026

No description provided.

@gne gne requested a review from Copilot January 14, 2026 08:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates search parameters and API operations in a TypeSpec-based API definition, introducing more flexible date filtering and expanding sortable fields.

Changes:

  • Adds implicitOptionality: true to multiple @patch decorators across various operations
  • Introduces a new timeString scalar type supporting both absolute and relative date formats (similar to Grafana/Elasticsearch syntax)
  • Expands the sortBy field with additional sorting options for search results
  • Adds new filter parameters for title, correspondent name, and legal basis
  • Converts date filter parameters from utcDateTime | plainDate to the new timeString type
  • Adds new operations for managing Dokumentobjekt and Skjerming resources

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
typespec/einnsyn.web.operations.tsp Adds implicitOptionality: true to PATCH operations and expands sortBy field with 9 additional sort options
typespec/einnsyn.queryparameters.tsp Introduces timeString scalar type with comprehensive date/time syntax documentation and adds new filter parameters
typespec/einnsyn.arkiv.operations.tsp Updates PATCH decorator and adds new operations for document objects and screening
Comments suppressed due to low confidence (1)

typespec/einnsyn.queryparameters.tsp:1

  • The sortBy field values are not alphabetically ordered, which could make maintenance difficult. Consider ordering them alphabetically to improve readability and maintainability.
import "@typespec/http";

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gne gne requested a review from havtorr January 22, 2026 07:59
@gne gne merged commit 2da7b2a into main Jan 22, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants