Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the external ip-client dependency by replacing it with an in-house Spring service for sending innsynskrav to Integrasjonspunkt, and updates the surrounding sender logic/tests accordingly. It also reduces dependency surface by centralizing SHA-256 hashing and removing JetBrains @NotNull annotations.
Changes:
- Replace
no.einnsyn.clients.ipusage with a newIntegrasjonspunktInnsynskravClientthat posts the multipart request directly. - Update
InnsynskravSenderServiceand affected controller/scheduler tests to use the new client signature and exceptions. - Introduce
HashUtilsand migrate SHA-256 hashing call sites away fromDigestUtils/ad-hocMessageDigestcode.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/no/einnsyn/backend/entities/innsynskravbestilling/IntegrasjonspunktInnsynskravClient.java | New in-house client that builds SBD JSON and sends multipart request to Integrasjonspunkt via RestTemplate. |
| src/test/java/no/einnsyn/backend/entities/innsynskravbestilling/IntegrasjonspunktInnsynskravClientTest.java | New unit test verifying multipart request structure, headers, and SBD content. |
| src/main/java/no/einnsyn/backend/entities/innsynskravbestilling/InnsynskravSenderService.java | Switch sender service from IPSender to new client; modernize date formatting to thread-safe formatters. |
| src/test/java/no/einnsyn/backend/entities/innsynskravbestilling/InnsynskravBestillingSchedulerTest.java | Update mocks/verifications to new client API and NetworkException. |
| src/test/java/no/einnsyn/backend/entities/innsynskravbestilling/InnsynskravBestillingControllerTest.java | Update mocks/verifications to new client API; replace IOUtils resource reads. |
| src/test/java/no/einnsyn/backend/EinnsynTestBase.java | Use HashUtils for hashing API key secrets in tests. |
| src/main/java/no/einnsyn/backend/utils/HashUtils.java | New shared SHA-256 hex helper to reduce dependencies and duplication. |
| src/main/java/no/einnsyn/backend/entities/apikey/ApiKeyService.java | Migrate API key hashing to HashUtils. |
| src/main/java/no/einnsyn/backend/common/search/SearchService.java | Migrate query hashing to HashUtils and keep fallback behavior. |
| src/main/java/no/einnsyn/backend/error/EInnsynExceptionHandler.java | Replace JetBrains @NotNull import with Jakarta validation annotation. |
| src/main/java/no/einnsyn/backend/entities/base/BaseRepository.java | Replace JetBrains @NotNull import with Jakarta validation annotation. |
| src/main/java/no/einnsyn/backend/EinnsynControllerTestBase.java | Update mocked sender type to IntegrasjonspunktInnsynskravClient. |
| src/main/java/no/einnsyn/backend/configuration/IntegrasjonspunktConfiguration.java | Remove configuration that existed only to support ip-client’s ApiClient. |
| pom.xml | Remove ip-client dependency and related build plugin execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...va/no/einnsyn/backend/entities/innsynskravbestilling/IntegrasjonspunktInnsynskravClient.java
Show resolved
Hide resolved
...va/no/einnsyn/backend/entities/innsynskravbestilling/IntegrasjonspunktInnsynskravClient.java
Show resolved
Hide resolved
...a/no/einnsyn/backend/entities/innsynskravbestilling/InnsynskravBestillingControllerTest.java
Outdated
Show resolved
Hide resolved
...a/no/einnsyn/backend/entities/innsynskravbestilling/InnsynskravBestillingControllerTest.java
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 23647875241Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.