Add NVMe-oF connect concurrency limiter#131
Closed
ashtonian wants to merge 2 commits intofenio:mainfrom
Closed
Conversation
fenio
added a commit
that referenced
this pull request
Feb 26, 2026
Prevent kernel NVMe subsystem registration lock contention when staging many volumes simultaneously on a single node. Uses a channel-based semaphore (default: 5) configurable via --max-concurrent-nvme-connects flag and node.maxConcurrentNVMeConnects Helm value. Adds Prometheus metrics for concurrent/waiting connect operations. Co-authored-by: Ashton Kinslow <github@ashtonkinslow.com>
Owner
|
Integrated manually onto main as 49eb208 — thanks @ashtonian! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same as before, it seems during mass reconnect events there can be contention around initializing the connection. This introduces a tunable to limit that.
Type of Change
Motivation
Connecting 50+ volumes to a single host cascade and fails.
Changes Made
Testing
Deployed in my cluster, needs verification.
Test environment:
Tests run:
make test)make lint)Documentation
Checklist
Security Considerations
Related Issues
Related to #130
Additional Notes