Support recon:info(Pid, {dictionary, Key}) introduced in OTP 26.2#116
Support recon:info(Pid, {dictionary, Key}) introduced in OTP 26.2#116gomoripeti wants to merge 1 commit intoferd:masterfrom
Conversation
Keeping the function clause generic so that dialyzer does not complain on older versions where the second arg of erlang:process_info must be an atom or list.
0c8269c to
98836d8
Compare
ferd
left a comment
There was a problem hiding this comment.
I don't think this is acceptable as-is just because we remove a whole check and change semantics without tests written. I think we should either keep existing clause but add a new one that checks for valid keys, or drop all checks but add tests.
|
thanks for the feedback. initially I had a strict matching on the dictionary tuple key (0c8269c) but dialyzer is complaining on older OTP versions. I will add tests. |
|
Yeah fair enough with Dialyzer. I imagine eventually it might make sense to deal with it like we do in other code base and only Dialyze newer versions (I need to bump up the CI used in this repo), but I'm good with removing the check for consistency with the test added on top. |
Keeping the function clause generic so that dialyzer does not complain
on older versions where the second arg of
erlang:process_info/2must bean atom or list.