-
Notifications
You must be signed in to change notification settings - Fork 243
feat: WebAuthn/passkey support on Linux via electron-webauthn-linux #2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
phelix001
wants to merge
9
commits into
ferdium:develop
Choose a base branch
from
phelix001:fix/webview-permission-handlers
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+184
−4
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
11c1868
fix: add explicit permission handlers for service webview sessions
phelix001 e422b73
feat: integrate electron-webauthn-linux for passkey support on Linux
phelix001 ade7de3
fix: conditionally inject WebAuthn page script only when credentials …
phelix001 c11d8a7
feat: extend WebAuthn CDP injection to popup windows
phelix001 b1db549
fix: address Copilot review -- remove DIAG, fix eTLD+1, fix comment
phelix001 f4a7561
Merge branch 'develop' into fix/webview-permission-handlers
phelix001 ec6b7d6
chore: replace file: dependency with published electron-webauthn-linu…
phelix001 9c4ec9e
fix: replace CDP debugger with preload-based WebAuthn injection
phelix001 0781c76
chore: bump electron-webauthn-linux to 0.1.1
phelix001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /** | ||
| * Minimal preload for popup windows (e.g. Google auth popups) on Linux. | ||
| * Injects the WebAuthn page script into the main world via DOM script element | ||
| * and exposes the electronWebAuthn IPC bridge via contextBridge. | ||
| * | ||
| * This runs in popup BrowserWindows opened by setWindowOpenHandler with | ||
| * { action: 'allow' } -- these windows don't get the recipe preload. | ||
| */ | ||
| import { contextBridge, ipcRenderer } from 'electron'; | ||
| import { webauthnPageScript } from 'electron-webauthn-linux'; | ||
|
|
||
| // Inject the WebAuthn page script into the main world BEFORE page scripts run. | ||
| // process.once('document-start') fires at document creation, before any <script> tags. | ||
| // The DOM <script> element executes in world 0 (main world), not the isolated preload world. | ||
| process.once('document-start', () => { | ||
| const script = document.createElement('script'); | ||
| script.textContent = webauthnPageScript; | ||
| document.documentElement.append(script); | ||
| script.remove(); | ||
| }); | ||
|
|
||
| // Expose the IPC bridge so the page script can route WebAuthn calls to main process. | ||
| contextBridge.exposeInMainWorld('electronWebAuthn', { | ||
| create: (options: any) => ipcRenderer.invoke('webauthn:create', options), | ||
| get: (options: any) => ipcRenderer.invoke('webauthn:get', options), | ||
| hasCredentials: (rpId: string) => | ||
| ipcRenderer.invoke('webauthn:hasCredentials', rpId), | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.