WIP: Add ability to reorder Workspaces using drag and drop#497
WIP: Add ability to reorder Workspaces using drag and drop#497SpecialAro wants to merge 2 commits intoferdium:developfrom
Conversation
| name={workspace.name} | ||
| isActive={actualWorkspace === workspace} | ||
| onClick={() => { | ||
| if (actualWorkspace === workspace) return; |
There was a problem hiding this comment.
I would personally place the return within brackets on the next line as this is easier to read.
There was a problem hiding this comment.
You and I both... But eslint didn't like it that way 🤣
There was a problem hiding this comment.
Eslint config can be modified 🌚
|
So to update the order in the API we would need to create/update some endpoints to support that. I'm a little in doubt if we wanna implement that in the current API version or wait for the v2 to be completed and make it fully testable |
Maybe we can wait for the V2 to be completed 😁 |
in that case, do we want to hold 6.0.0 release? |
I don't think we need to hold back for this PR. We can easily then merge new features in a minor/patch version or so. |
vraravam
changed the title
|
I would love to see this completed!
I have some notes/thoughts that I've started writing as early thoughts that I may use to attempt to make some changes:
|
|
Amazing, would love to see this possibility. The only alternative is deleting and recreating workspaces. |
|
Any updates here? |
6 participants
Pre-flight Checklist
Description of Change
Add order ability to Workspaces
Motivation and Context
This is a WIP for adding the ability of order Workspaces in the Workspace Drawer and in the Workspace Settings.
The idea is to fix #146.
To do:
mobxis complaining about this given I'm not using an action for changing the index)I think I'm needing some help setting up the actions to reorder workspaces - as it is now, the workspaces are reordered but only until the Ferdium restarts/reloads, which is due to the fact that the "new" order is not being saved in the API. If anyone can help me with that I would really appreciate it :D
Screenshots
(so far... )
Checklist
npm run prepare-code)npm testpassesRelease Notes