update spin 3 docs to represent js sdk v3 structure #1472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karthik2804 <[email protected]>
tschneidereit
approved these changes
Jan 28, 2025
Contributor
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Looks great! Just some small things, nothing major
itowlson
approved these changes
Jan 28, 2025
Contributor
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
All looks fine to me but I'm ignorant; if Till is happy then I am happy!
Signed-off-by: karthik2804 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates examples to look like the JS SDK v3
ref: https://github.com/fermyon/spin-js-sdk/pull/319