-
Notifications
You must be signed in to change notification settings - Fork 3
Add permanent redirects for RSS feed URLs #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Niels Swimberghe <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The redirects are not working. I get the following back instead of a redirect: Request URL
https://fern-preview-ed17d636-cd62-49b6-83b9-5af9af9ea97a.docs.buildwithfern.com/learn/sdks/introduction/changelog/ts.rss
Request Method
GET
Status Code
200 OK
Remote Address
18.238.80.44:443
Referrer Policy
strict-origin-when-cross-origin
HTML contentMaybe the order of the redirects matter here, move them before the wildcard |
The RSS feed redirects were being caught by the wildcard changelog redirects because they were placed after them. Moved the RSS redirects before the wildcard redirects so they match first. Co-Authored-By: Niels Swimberghe <[email protected]>
|
I've moved the RSS redirects before the wildcard redirects as you suggested. However, after testing, I'm finding that the old RSS URLs are still not redirecting correctly. Test Results: All three destination RSS feeds exist and work correctly:
However, when accessing the old URLs:
Root Cause: The Question: Is there a different way to configure redirects for |
Moved RSS feed redirects to the very top of the redirects list to ensure they are evaluated before any static file handlers. Also added: - Trailing slash variants (ts.rss/, csharp.rss/) - Parameterized extension variants (ts.:ext, csharp.:ext) This attempts to work around the issue where .rss files are being caught by a static file handler (x-matched-path: /[host]/[domain]/static/[slug]) before the redirect rules are evaluated. Co-Authored-By: Niels Swimberghe <[email protected]>
Update: RSS Redirects Still Not WorkingI've tried multiple approaches to make the RSS redirects work, but they're still being caught by a static file handler before the redirect rules are evaluated. Attempts Made:
Test Results: Even with all these changes, the old RSS URLs still return:
Meanwhile, the destination RSS feeds work perfectly:
And the non-RSS changelog redirects work correctly:
Root Cause: The evidence strongly suggests that Question: Is there a different way to configure RSS feed redirects in Fern's system? Or does this need to be handled at a different level (e.g., Vercel configuration, Next.js rewrites, or Fern platform configuration)? @Swimburger - Do you know if there's a way to make RSS redirects work, or should this be escalated to the Fern platform team? |
Add permanent redirects for RSS feed URLs
Summary
Added three permanent redirects for RSS feed URLs to maintain backwards compatibility with the old changelog RSS feed paths:
/learn/sdks/introduction/changelog/ts.rss→/learn/sdks/generators/typescript/changelog.rss/learn/sdks/introduction/changelog/csharp.rss→/learn/sdks/generators/csharp/changelog.rss/learn/cli-reference/changelog.rss→/learn/cli-api-reference/cli-reference/changelog.rssThese redirects follow the same pattern as the existing non-RSS changelog redirects already in the file.
Review & Testing Checklist for Human
Notes