Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 20, 2025

Summary

Documents that the Card and Icon components support relative paths to SVG files (e.g., ./images/icon.svg). Changes include:

  • Added a "Custom SVG icon" variant section to the Icon component docs with an example
  • Expanded the "Custom icon" section in the Card component docs to show relative SVG path usage
  • Updated the icon property descriptions in both components to mention relative SVG paths
  • Added a changelog entry for 2025-12-20 announcing this feature

Updates since last revision

  • Fixed Vale style suggestions: applied sentence-style capitalization to headings and removed time-relative term "now" from changelog

Review & Testing Checklist for Human

  • Verify the feature works: Test that icon="./images/example.svg" actually renders an SVG in both Card and Icon components - I documented this based on the request but did not test the actual functionality
  • Check the changelog links: Verify /learn/docs/writing-content/components/cards and /learn/docs/writing-content/components/icons resolve correctly
  • Preview the rendered docs: Confirm the new code examples display properly on the preview deployment

Recommended test plan: Create a test SVG file and try using it with both <Card icon="./path/to/test.svg"> and <Icon icon="./path/to/test.svg" /> to confirm the documented syntax is correct.

Notes

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@@ -0,0 +1,16 @@
## Custom SVG icons in Card and Icon components
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [vale] reported by reviewdog 🐶
[FernStyles.Headings] 'Custom SVG icons in Card and Icon components' should use sentence-style capitalization.

@@ -0,0 +1,16 @@
## Custom SVG icons in Card and Icon components

The Card and Icon components now support relative paths to SVG files. Use a relative path like `./images/icon.svg` to display custom SVG icons from your project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[FernStyles.Current] Avoid time-relative terms like 'now' that become outdated

<Icon icon="fa-brands fa-github" /> Brands
```

### Custom SVG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [vale] reported by reviewdog 🐶
[FernStyles.Headings] 'Custom SVG' should use sentence-style capitalization.

@github-actions
Copy link
Contributor

<Icon icon="fa-brands fa-github" /> Brands
```

### Custom SVG icon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [vale] reported by reviewdog 🐶
[FernStyles.Headings] 'Custom SVG icon' should use sentence-style capitalization.

@github-actions
Copy link
Contributor

@chdeskur chdeskur merged commit 7b70382 into main Dec 20, 2025
2 checks passed
@chdeskur chdeskur deleted the fern/add-svg-relative-paths-docs branch December 20, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants