feat(scribe): Implement SQS to eliminate state machine polling. #4639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
vercel
bot
temporarily deployed
to
Preview – prod-assets.ferndocs.com
Comment on lines
69
to
78
| def has_interrupt_message(self) -> tuple[bool, str | None]: | ||
| messages = self.receive_messages(max_messages=10) | ||
|
|
||
| for msg in messages: | ||
| body = msg["body"] | ||
| if body.get("type") == "INTERRUPT": | ||
| LOGGER.info(f"Found INTERRUPT message in queue") | ||
| return True, msg["receipt_handle"] | ||
|
|
||
| return False, None |
There was a problem hiding this comment.
The has_interrupt_message() method fetches messages but doesn't acknowledge non-INTERRUPT messages, causing queue message accumulation and duplicates on retry.
View Details
📝 Patch Details
diff --git a/servers/fai-lambda/fai-scribe/src/utils/sqs_client.py b/servers/fai-lambda/fai-scribe/src/utils/sqs_client.py
index 7df5e881d..f5703da45 100644
--- a/servers/fai-lambda/fai-scribe/src/utils/sqs_client.py
+++ b/servers/fai-lambda/fai-scribe/src/utils/sqs_client.py
@@ -68,14 +68,21 @@ class SQSClient:
def has_interrupt_message(self) -> tuple[bool, str | None]:
messages = self.receive_messages(max_messages=10)
+ interrupt_receipt = None
for msg in messages:
body = msg["body"]
+ receipt_handle = msg["receipt_handle"]
+
if body.get("type") == "INTERRUPT":
LOGGER.info(f"Found INTERRUPT message in queue")
- return True, msg["receipt_handle"]
+ interrupt_receipt = receipt_handle
+ else:
+ # Delete non-INTERRUPT messages to prevent queue accumulation
+ self.delete_message(receipt_handle)
+ LOGGER.debug(f"Deleted processed {body.get('type', 'UNKNOWN')} message")
- return False, None
+ return interrupt_receipt is not None, interrupt_receipt
def get_resume_messages(self) -> list[dict[str, Any]]:
messages = self.receive_messages(max_messages=10)
@@ -83,8 +90,14 @@ class SQSClient:
for msg in messages:
body = msg["body"]
+ receipt_handle = msg["receipt_handle"]
+
if body.get("type") == "RESUME":
- resume_messages.append({"body": body, "receipt_handle": msg["receipt_handle"]})
+ resume_messages.append({"body": body, "receipt_handle": receipt_handle})
+ else:
+ # Delete non-RESUME messages to prevent queue accumulation
+ self.delete_message(receipt_handle)
+ LOGGER.debug(f"Deleted processed {body.get('type', 'UNKNOWN')} message")
if resume_messages:
LOGGER.info(f"Found {len(resume_messages)} RESUME messages in queue")
Analysis
SQS message accumulation in has_interrupt_message() and get_resume_messages()
What fails: SQSClient.has_interrupt_message() and SQSClient.get_resume_messages() fetch messages but only delete specific message types (INTERRUPT/RESUME), leaving other messages in the queue to accumulate
How to reproduce:
# Simulate mixed message types in SQS queue
# Call has_interrupt_message() repeatedly
client = SQSClient(queue_url)
client.has_interrupt_message() # Fetches all messages, only deletes INTERRUPT
client.has_interrupt_message() # Re-fetches same non-INTERRUPT messagesResult: Non-INTERRUPT messages (RESUME, OTHER types) remain in queue after each poll and get re-processed on every subsequent call, causing message accumulation and duplicate processing
Expected: All processed messages should be deleted from queue to prevent redelivery after SQS visibility timeout expires
Root cause: Methods call receive_messages() but only delete messages of specific types, violating SQS best practices for message cleanup
eyw520
force-pushed
the
eden/scribe-implement-sqs-polling
branch
from
bc97f88 to
3dcde0c
Compare
sahil485
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.