fix(docs): landing page routing for productgroup sites #6170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a productgroup has a landing page with a custom slug (e.g., slug: /welcome), the routing logic now correctly checks for the landing page before falling back to the first product. Products still take precedence over landing pages if there is a slug collision. Co-Authored-By: [email protected] <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
🌱 Smoke Test PreviewRun at: 2026-01-05 23:43:24 UTC Testing branch changes with smoke test content:
🕷️ Smoke Test Crawler ResultsPages crawled: 49 🎉 All pages loaded successfully with no errors! |
kennyderek
approved these changes
Jan 5, 2026
kennyderek
deleted the
devin/1767133142-fix-productgroup-landing-page-routing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes made
When a productgroup has a landing page with a custom slug (e.g.,
slug: /welcome), the routing logic infindNodenow checks if the requested slug matches the productgroup's landing page before falling back to the first product. Products still take precedence over landing pages if there is a slug collision.What was the motivation & context behind this PR?
When users configure a landing page with a custom slug in a productgroup site:
Visiting
/welcomewould incorrectly fall back to the first product instead of showing the landing page. The routing logic was checking for product matches but not checking if the slug matched the productgroup's landing page.How has this PR been tested?
pnpm lint:biome,pnpm format)pnpm test)Human review checklist
slug === landingPageSlug, we return a redirect to the same slug. Is this the intended behavior, or should this return a "found" result instead?Link to Devin run: https://app.devin.ai/sessions/a94aac2622a84fcbbb79d574f06d9eba
Requested by: [email protected]