chore(ci): add docker login to seed workflow for wiremock-using SDKs #11107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
tjb9dc
changed the title
tjb9dc
commented
Dec 9, 2025
Comment on lines
26
to
34
| - name: Log in to Docker Hub | ||
| if: ${{ env.DOCKER_USERNAME != '' && env.DOCKER_PASSWORD != '' }} | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| username: ${{ env.DOCKER_USERNAME }} | ||
| password: ${{ env.DOCKER_PASSWORD }} | ||
| env: | ||
| DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} | ||
| DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} |
Collaborator
Author
There was a problem hiding this comment.
I'd like to avoid touching the user-facing ci.yml files for this one. Too big of a change.
Can we address the change with how we run seed instead?
Contributor
There was a problem hiding this comment.
Got it—I've reverted the generator CI template and versions.yml changes, and instead added a Docker Hub login step to the seed.yml workflow for the wiremock-using SDKs (go-sdk, python-sdk, php-sdk, rust-sdk, csharp-sdk). This keeps the change scoped to how we run seed internally, without modifying user-facing CI templates.
Reverts generator CI template changes and instead adds Docker Hub login to the seed.yml workflow for SDKs that use WireMock containers in tests (go-sdk, python-sdk, php-sdk, rust-sdk, csharp-sdk). This addresses Docker Hub rate limiting issues by authenticating pulls in our internal seed tests, without modifying user-facing CI templates. Co-Authored-By: [email protected] <[email protected]>
devin-ai-integration
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: Slack thread from @tjb9dc about Docker Hub rate limits when pulling wiremock containers in tests
Adds Docker Hub login to the internal seed workflow for SDKs that use WireMock containers in tests. This addresses Docker Hub rate limiting issues by authenticating pulls, which have significantly higher rate limits.
Link to Devin run: https://app.devin.ai/sessions/aabcda0166c84b42b4b34327323276e5
Requested by: [email protected] (@tjb9dc)
Changes Made
seed.ymlworkflow for wiremock-using SDK jobs:python-sdkgo-sdkcsharp-sdkphp-sdkrust-sdkThis approach keeps the change scoped to internal seed tests without modifying user-facing generator CI templates.
Human Review Checklist
FERN_API_DOCKERHUB_PASSWORDsecret exists in the repo (used by other workflows)Run All Seed Testsstep in each jobTesting
pnpm run check)