Skip to content

Conversation

@tjb9dc
Copy link
Collaborator

@tjb9dc tjb9dc commented Dec 9, 2025

Description

Refs #11029

Removes the oauthTokenOverride configuration flag from the TypeScript SDK generator. OAuth token override is now always enabled, allowing users to provide a pre-generated bearer token instead of client ID/secret without any configuration.

Link to Devin run: https://app.devin.ai/sessions/87ae4fc7de9144918bfe7cc550f5e0a0
Requested by: [email protected] (@tjb9dc)

Changes Made

  • Removed oauthTokenOverride from TypescriptCustomConfigSchema (Zod schema)
  • Removed oauthTokenOverride from SdkCustomConfig interface
  • Removed config parsing/passing through the generator pipeline:
    • SdkGeneratorCli.ts
    • SdkGenerator.ts
    • BaseClientContextImpl.ts
    • SdkClientClassGenerator.ts
    • GeneratedSdkClientClassImpl.ts
    • BaseClientTypeGenerator.ts
    • AuthProvidersGenerator.ts
    • OAuthAuthProviderGenerator.ts
    • ReadmeConfigBuilder.ts
    • ReadmeSnippetBuilder.ts
  • Hardcoded hasTokenOverride = true in OAuthAuthProviderGenerator.ts
  • Always use OAuthAuthProvider.createInstance() instead of conditional instantiation
  • README authentication section now always shows for OAuth APIs
  • Added version 3.37.4 to versions.yml with changelog entry
  • Removed token-override seed test fixtures that used the removed config flag

Updates Since Last Revision

  • Fixed seed test failures by removing token-override fixtures from seed/ts-sdk/seed.yml
  • Deleted generated output folders for oauth-client-credentials/token-override and oauth-client-credentials-environment-variables/token-override

Testing

  • Lint checks pass (pnpm run check)
  • Seed test fixtures updated to remove references to removed config

Human Review Checklist

  • Verify that always enabling token override (removing the config flag) is the intended behavior
  • Note: Java SDK still has oauthTokenOverride config - this PR only changes TypeScript as requested
  • Note: The hasTokenOverride = true pattern is kept for minimal diff; could be simplified further in a follow-up

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@tjb9dc tjb9dc closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants