Skip to content

Conversation

@tjb9dc
Copy link
Collaborator

@tjb9dc tjb9dc commented Dec 9, 2025

Description

Refs #11077

Removes the oauth-token-override config flag from the Python SDK generator. OAuth token override is now always enabled for OAuth client credentials flows, allowing users to authenticate with either client_id/client_secret OR a pre-generated bearer token directly via the token parameter without any configuration.

Link to Devin run: https://app.devin.ai/sessions/d9dea7643e314c6691e957657a1252ca
Requested by: [email protected] (@tjb9dc)

Changes Made

  • Removed oauth_token_override field from SDKCustomConfig in custom_config.py
  • Updated root_client_generator.py to always enable token override when OAuth client credentials is detected
  • Updated readme_snippet_builder.py to detect OAuth client credentials from IR instead of config flag (added _check_oauth_client_credentials helper method)
  • Removed oauth_token_override parameter from generator_cli.py and sdk_generator.py
  • Removed token-override seed fixture directories (behavior now merged into default fixtures)
  • Regenerated seed output for oauth-client-credentials and oauth-client-credentials-environment-variables fixtures
  • Added version 4.43.1 to versions.yml with PATCH changelog entry

Testing

  • Seed tests regenerated and passing for affected fixtures
  • Lint checks passing (pnpm run check)

Human Review Checklist

  • Verify _check_oauth_client_credentials method in readme_snippet_builder.py correctly identifies OAuth client credentials from IR
  • Verify generated SDK constructors still properly validate that either token OR client_id/client_secret are provided
  • Confirm seed output changes show correct token override behavior in generated client.py files

OAuth token override is now always enabled for OAuth client credentials flows,
allowing users to authenticate with either client_id/client_secret OR a
pre-generated bearer token directly via the token parameter without any
configuration.

- Remove oauth_token_override field from SDKCustomConfig
- Update root_client_generator.py to always enable token override for OAuth
- Update readme_snippet_builder.py to detect OAuth from IR instead of config
- Remove token-override seed fixtures (now merged with no-custom-config)
- Regenerate seed output for oauth-client-credentials fixtures

Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@fern-support fern-support enabled auto-merge (squash) December 9, 2025 18:29
@fern-support fern-support merged commit 32f5027 into main Dec 9, 2025
126 checks passed
@fern-support fern-support deleted the devin/1765246121-remove-oauth-token-override-config branch December 9, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants