fix(cli, typescript): Fix ts local github generation to match remote generation #9869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsklan
changed the title
tjb9dc
approved these changes
Oct 16, 2025
Swimburger
approved these changes
Oct 17, 2025
Comment on lines
+268
to
+271
| const licenseContent = await this.readLicenseFileContent(licenseFileName); | ||
|
|
||
| const licenseFilePath = path.join(rootDirectory, "LICENSE"); | ||
| await fs.writeFile(licenseFilePath, licenseContent, "utf-8"); |
There was a problem hiding this comment.
Can we use a readstream here?
packages/cli/cli/versions.yml
Outdated
| # yaml-language-server: $schema=../../../fern-versions-yml.schema.json | ||
| - changelogEntry: | ||
| - summary: | | ||
| Fix ts local github generation to match remote generation. |
There was a problem hiding this comment.
=> Fix TypeScript SDK generator's local GitHub generation to match remote generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linear ticket: FER-6784
This PR fixes TypeScript SDK generation to achieve parity between local (
--local) and remote generation modes. Previously, local generation would produce different outputs than remote generation, particularly around package.json metadata, GitHub workflows, license files, and User-Agent headers.Changes Made
computeSemanticVersion()function that mirrors FDR's version computation logic locallyowner/reposhortformat
semver,latest-version,octokitfor version checkinggenerators/typescript/sdk/versions.ymlto version 3.9.1packages/cli/cli/versions.ymlto version 0.92.1Testing