Support text/uri-list MIME type for onDropText#58
Open
Twixes wants to merge 1 commit intofeross:masterfrom
Open
Support text/uri-list MIME type for onDropText#58Twixes wants to merge 1 commit intofeross:masterfrom
Twixes wants to merge 1 commit intofeross:masterfrom
Conversation
Author
|
Bump? |
Owner
|
What browser are you using? I just tested the version on |
Author
|
Electron, specifically https://github.com/webtorrent/webtorrent-desktop |
Owner
|
@Twixes Can you confirm that this issue still exists on the latest version of electron, which I believe we're using on Let me know if latest Electron still has this issue. |
Author
|
I just tried on |
Author
|
Bump? |
Author
|
I'm sorry but this still doesn't quite work in the WebTorrent app! Perhaps we could get a solution in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for drag-and-dropping links contained in HTML anchor elements, if there's no
textdata available.Rationale: if using
drag-dropin a place where URLs are expected, it's very convenient for dropping links to work not only with outright strings, but also with anchor tags which are common on websites – something like:<a href="https://example.com"><img src="bar"></a>. In this case.getData('text')is empty BUT.getData('text/uri-list')does have useful data –'https://example.com'– and we should make use of this data.Before, the user could only right-click, click "Copy link address", and somehow use that copied text in the target app. With this tiny change to
drag-drop, the user can simply drag the anchor element to the target app – and that's it. Significant improvement to the user experience.Please do release new version if this is merged.