Skip to content

Fix del problem #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RemDelaporteMathurin merged 2 commits into from
Sep 19, 2025
Merged

Fix del problem #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f2d73b
added test that catches the bug
RemDelaporteMathurin Sep 19, 2025
4a62b14
fix
RemDelaporteMathurin Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/festim/hydrogen_transport_problem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,7 +1882,8 @@ def run(self):
def __del__(self):
for export in self.exports:
if isinstance(export, exports.ExportBaseClass):
export.writer.close()
if hasattr(export, "writer") and export.writer is not None:
export.writer.close()


class HydrogenTransportProblemDiscontinuousChangeVar(HydrogenTransportProblem):
Expand Down
9 changes: 9 additions & 0 deletions test/system_tests/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,3 +236,12 @@ def test_temp_dependent_bc_mixed_domain_temperature_as_function():
H.subdomain_to_post_processing_solution[top_domain].x.array[:].max()
)
assert np.isclose(computed_value, expected_value)


def test_del():
"""Test that deleting a model with exports works fine (no segfault)"""
my_model = F.HydrogenTransportProblemDiscontinuous()
H = F.Species("H")
my_model.exports = [F.VTXSpeciesExport(filename="h.bp", field=H)]

my_model.__del__()
Loading