Average surface and volume derived quantities in Cylindrical and Spherical#820
Merged
jhdark merged 31 commits intofestim-dev:mainfrom Jan 14, 2025
Merged
Average surface and volume derived quantities in Cylindrical and Spherical#820jhdark merged 31 commits intofestim-dev:mainfrom
jhdark merged 31 commits intofestim-dev:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
==========================================
- Coverage 99.27% 99.27% -0.01%
==========================================
Files 60 60
Lines 2753 2744 -9
==========================================
- Hits 2733 2724 -9
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RemDelaporteMathurin
requested changes
Aug 5, 2024
Comment on lines
+140
to
+142
| # dV_z = r dr dtheta , assuming axisymmetry dV_z = theta r dr | ||
| # dV_r = r dz dtheta , assuming axisymmetry dV_r = theta r dz | ||
| # in both cases the expression with self.dx is the same |
Collaborator
There was a problem hiding this comment.
Not true for spherical, please adapt
|
|
||
| my_export = AverageVolumeSpherical("solute", 1) | ||
| V = f.FunctionSpace(mesh_fenics, "P", 1) | ||
| c_fun = lambda r: c_left + (c_right - c_left) / (r1 - r0) * r |
Collaborator
There was a problem hiding this comment.
Just noting that
Collaborator
There was a problem hiding this comment.
I don't understand why this tests passes, please consider the above comment
4 tasks
4 tasks
4 tasks
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
RemDelaporteMathurin
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed changes
With these new exports, users can take results from 1/2D simulations and extrapolate them for cylindrical and spherical cases.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...