Change of variable method for interface discontinuities#904
Merged
RemDelaporteMathurin merged 42 commits intofestim-dev:fenicsxfrom Feb 18, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #904 +/- ##
===========================================
- Coverage 97.53% 96.02% -1.52%
===========================================
Files 44 45 +1
Lines 2233 2439 +206
===========================================
+ Hits 2178 2342 +164
- Misses 55 97 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Dokken/change of var
Collaborator
Author
|
I fixed a bunch of things and it's now time to merge this. There's quite a lot of tidy up to do but I'll do it in a separate PR |
d696744
into
festim-dev:fenicsx
6 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs #909
This implements the change of variable method we use in FESTIM 1 to handle interface discontinuities.
Example usage: