Skip to content

Conversation

@KulaginVladimir
Copy link
Collaborator

@KulaginVladimir KulaginVladimir commented Feb 6, 2025

Proposed changes

This PR fixes #925 in order to remove the hard-coded parameter $\lambda_{abs}$. With this change, the definition of $k_{bs}$ in theory (as a rate constant) will be correct.

Additionally, J_vs, k_bs, and k_sb now accept mobile cocnentration by default allowing to account for fluxes that might depend on the concentration of subsurface H atoms (see Baskes 1980, Richards 1988, Pisarev 1997).

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RemDelaporteMathurin
Copy link
Collaborator

@KulaginVladimir can you rebase on main to bring the changes from #942

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (03ed7d5) to head (8007810).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
- Coverage   99.31%   99.31%   -0.01%     
==========================================
  Files          60       60              
  Lines        2905     2904       -1     
==========================================
- Hits         2885     2884       -1     
  Misses         20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RemDelaporteMathurin RemDelaporteMathurin merged commit 79d8fa7 into festim-dev:main Feb 6, 2025
6 checks passed
@KulaginVladimir KulaginVladimir deleted the surfacekinetics_refactoring branch March 18, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove lambda_abs in SurfaceKinetics

2 participants