Skip to content

Find max value in parallel safely #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhdark merged 8 commits into from
Mar 3, 2025
Merged

Find max value in parallel safely #953

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
828844c
Find max value in parallel
jhdark Feb 26, 2025
1a7cbe0
use numpy within allreduce
jhdark Mar 3, 2025
9dc6c47
max surface
jhdark Mar 3, 2025
4ae6ac9
min surface
jhdark Mar 3, 2025
fed2098
min volume
jhdark Mar 3, 2025
7fdc076
use comm from the function space of the solution
jhdark Mar 3, 2025
7c6fa70
Merge branch 'fenicsx' into np-max_update
jhdark Mar 3, 2025
582c304
no need for barrier function
jhdark Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/festim/exports/maximum_surface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from mpi4py import MPI

import numpy as np

import festim.exports.surface_quantity as sq
Expand Down Expand Up @@ -28,5 +30,9 @@ def compute(self):
indices = self.surface.locate_boundary_facet_indices(
solution.function_space.mesh
)
self.value = np.max(self.field.solution.x.array[indices])

solution.function_space.mesh.comm.barrier()
self.value = solution.function_space.mesh.comm.allreduce(
np.max(self.field.solution.x.array[indices]), op=MPI.MAX
)
self.data.append(self.value)
8 changes: 7 additions & 1 deletion src/festim/exports/maximum_volume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from mpi4py import MPI

import numpy as np

from festim.exports import VolumeQuantity
Expand Down Expand Up @@ -27,5 +29,9 @@ def compute(self):
"""
solution = self.field.solution
indices = self.volume.locate_subdomain_entities(solution.function_space.mesh)
self.value = np.max(self.field.solution.x.array[indices])

solution.function_space.mesh.comm.barrier()
self.value = solution.function_space.mesh.comm.allreduce(
np.max(self.field.solution.x.array[indices]), op=MPI.MAX
)
self.data.append(self.value)
8 changes: 7 additions & 1 deletion src/festim/exports/minimum_surface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from mpi4py import MPI

import numpy as np

import festim.exports.surface_quantity as sq
Expand Down Expand Up @@ -28,5 +30,9 @@ def compute(self):
indices = self.surface.locate_boundary_facet_indices(
solution.function_space.mesh
)
self.value = np.min(self.field.solution.x.array[indices])

solution.function_space.mesh.comm.barrier()
self.value = solution.function_space.mesh.comm.allreduce(
np.min(self.field.solution.x.array[indices]), op=MPI.MIN
)
self.data.append(self.value)
10 changes: 7 additions & 3 deletions src/festim/exports/minimum_volume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from mpi4py import MPI

import numpy as np

from festim.exports import VolumeQuantity
Expand Down Expand Up @@ -26,7 +28,9 @@ def compute(self):
"""
solution = self.field.solution
indices = self.volume.locate_subdomain_entities(solution.function_space.mesh)
# FIXME: np.min/np.max is not parallel safe (unique value per process)
# Needs to use a reduction operation (MPI.comm.allreduce(..., op=...))
self.value = np.min(self.field.solution.x.array[indices])

solution.function_space.mesh.comm.barrier()
self.value = solution.function_space.mesh.comm.allreduce(
np.min(self.field.solution.x.array[indices]), op=MPI.MIN
)
self.data.append(self.value)
Loading