Skip to content

Update validate-pr-title script #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graycampbell merged 1 commit into from
Apr 23, 2025
Merged

Update validate-pr-title script #66

graycampbell merged 1 commit into from
Apr 23, 2025

Conversation

@graycampbell
Copy link
Collaborator

@graycampbell graycampbell commented Apr 23, 2025

📝 Summary

  • Added semicolons to the end of each line in the validate PR title script.

🛠️ Type of Change

  • Bug fix (change that fixes an issue)
  • New feature (change that adds functionality)
  • Breaking change (bug fix or feature that is not backwards compatible)
  • Documentation (DocC, API docs, markdown files, templates, etc.)
  • Testing (new tests, updated tests, etc.)
  • Refactoring or code formatting (no logic changes)
  • Updating dependencies (Swift packages, Homebrew, etc.)
  • CI/CD (change to automated workflows)

🧪 How Has This Been Tested?

Will be tested by the PR title workflow passing.

✅ Checklist

  • I have added relevant tests
  • I have verified all tests pass
  • I have formatted my code using SwiftFormat
  • I have updated documentation (if needed)
  • I have added the appropriate label to my PR
  • I have read the contributing guidelines
  • I agree to follow this project's Code of Conduct

@graycampbell
Update validate PR title script
b609ba3 
Signed-off-by: Gray Campbell <[email protected]>
@graycampbell graycampbell added the ci/cd Changes to CI/CD workflows label Apr 23, 2025
@graycampbell graycampbell self-assigned this Apr 23, 2025
@graycampbell graycampbell changed the title Update validate PR title script Update validate-pr-title script Apr 23, 2025
pjtnt11
pjtnt11 approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@pjtnt11 pjtnt11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

pjtnt11
pjtnt11 approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@pjtnt11 pjtnt11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

vnguyen-fetch
vnguyen-fetch approved these changes Apr 23, 2025
View reviewed changes
Copy link

@vnguyen-fetch vnguyen-fetch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@graycampbell graycampbell merged commit 0381295 into main Apr 23, 2025
5 checks passed
@graycampbell graycampbell deleted the ci/update-validate-pr-title-script branch April 23, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjtnt11 pjtnt11 pjtnt11 approved these changes

@vnguyen-fetch vnguyen-fetch vnguyen-fetch approved these changes

@bfahey bfahey Awaiting requested review from bfahey

@4omar9 4omar9 Awaiting requested review from 4omar9

@mitchtreece mitchtreece Awaiting requested review from mitchtreece

@jmarq013 jmarq013 Awaiting requested review from jmarq013

@ngimelliUW ngimelliUW Awaiting requested review from ngimelliUW

@kevinmhankes kevinmhankes Awaiting requested review from kevinmhankes

@nolinmcfarland nolinmcfarland Awaiting requested review from nolinmcfarland

@ghaisasavanti ghaisasavanti Awaiting requested review from ghaisasavanti

@ben-fortier ben-fortier Awaiting requested review from ben-fortier

@cgalindo7 cgalindo7 Awaiting requested review from cgalindo7

@SajanShrestha11 SajanShrestha11 Awaiting requested review from SajanShrestha11

@ritacarlson ritacarlson Awaiting requested review from ritacarlson

@berbs-fetch berbs-fetch Awaiting requested review from berbs-fetch

@gage-halverson-fetch gage-halverson-fetch Awaiting requested review from gage-halverson-fetch

Assignees

@graycampbell graycampbell

Labels

ci/cd Changes to CI/CD workflows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@graycampbell @pjtnt11 @vnguyen-fetch