Skip to content

Comments

2.0.6#238

Merged
cohenaj194 merged 1 commit intomainfrom
2.0.6
Feb 21, 2026
Merged

2.0.6#238
cohenaj194 merged 1 commit intomainfrom
2.0.6

Conversation

@cohenaj194
Copy link
Contributor

@cohenaj194 cohenaj194 commented Feb 21, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced error handling for API response parsing to provide clearer error messages.
  • Chores

    • Version bumped to 2.0.6.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 21, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

This PR updates the project version from 2.0.5 to 2.0.6 across workflow, HTML display, and package configuration files, and implements safer JSON parsing with enhanced error handling for Blizzard API responses.

Changes

Cohort / File(s) Summary
Version Updates
.github/workflows/electron-exe-build.yml, node-ui/index.html, package.json
Bumps AAA_VERSION and displayed version strings from 2.0.5 to 2.0.6 across build workflow, UI display, and package manifest.
API Error Handling
node-ui/mega-alerts.js
Replaces direct JSON parsing with safer text-read-then-parse approach for Blizzard API responses. Adds try/catch blocks, structured error logging via logError with response snippets, and descriptive error messages for JSON parse failures on non-200 responses in AH and Commodity AH data fetch flows.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • PR #230: Modifies mega-alerts.js with Blizzard API response handling and centralized error reporting patterns.
  • PR #105: Updates project version handling across workflow, display, and manifest files.

Poem

🐰 A version hop from 2.0.5 to 2.0.6 we go,
With safer JSON parsing and error logs in tow,
The Blizzard API now has shields so tight,
No more mysterious crashes in the night! ✨

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Version Bump Check ✅ Passed All four required files (package.json, package-lock.json, .github/workflows/electron-exe-build.yml, and node-ui/index.html) have been correctly updated to version 2.0.6, matching the branch name.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 2.0.6

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
84.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@cohenaj194 cohenaj194 merged commit 5ad0bde into main Feb 21, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant