Skip to content

Conversation

@tmm1
Copy link

@tmm1 tmm1 commented Feb 4, 2023

/cc MythTV/mythtv#364
/cc xbmc/xbmc#22605
/cc xbmc/xbmc#22603
/cc xbmc/xbmc#22333

cc: Aman Karmani [email protected]
cc: Eric Lindvall [email protected]
cc: Mark Thompson [email protected]
cc: David Engel [email protected]
cc: Scott Theisen [email protected]
cc: Miguel Borges de Freitas [email protected]

fhvwy and others added 5 commits February 3, 2023 16:07
Supports closed captions, active format and bar data as defined by
SCTE 128 part 1 or A/53 part 4, suitable for use with both MPEG-2
and H.264.

Signed-off-by: Aman Karmani <[email protected]>
@tmm1
Copy link
Author

tmm1 commented Feb 4, 2023

/submit

@ffmpeg-codebot
Copy link

ffmpeg-codebot bot commented Feb 4, 2023

Submitted as [email protected]

To fetch this version into FETCH_HEAD:

git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-50/tmm1/cbs-misc-a53-v3-v1

To fetch this version to local tag pr-ffstaging-50/tmm1/cbs-misc-a53-v3-v1:

git fetch --no-tags https://github.com/ffstaging/FFmpeg tag pr-ffstaging-50/tmm1/cbs-misc-a53-v3-v1

@tmm1
Copy link
Author

tmm1 commented Feb 4, 2023

@softworkz fyi cc parsing didn't seem to work correctly here. none of the emails were cc'd on my submission

EDIT: maybe i was supposed to put them at the bottom not the top?

@softworkz
Copy link
Collaborator

@softworkz fyi cc parsing didn't seem to work correctly here. none of the emails were cc'd on my submission

EDIT: maybe i was supposed to put them at the bottom not the top?

Yes, they need to be at the bottom. The first message is what's being sent out as git "cover page" ( PATCH0/N ), so it normally starts with whatever you want to tell (or not :-) ).

There mustn't be a slash before the cc's. See here for an example: #18 (comment)

Finally, the CC's are actually meant to be filled  the CCs automatically based on who replied on the ML. You can modify them, for subsequent patch versions, but I'm not sure whether it works for the initial send.

@kmikita
Copy link

kmikita commented Mar 29, 2023

Thank you! It is very useful feature, want to see merged into master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants