tools/ffmpeg-sg: Add show-graph wrapper scripts (aka killer feature) #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softworkz
force-pushed
the
submit_killerscript
branch
from
b9d0d17 to
ce04d26
Compare
Signed-off-by: softworkz <[email protected]>
Signed-off-by: softworkz <[email protected]>
softworkz
force-pushed
the
submit_killerscript
branch
from
ce04d26 to
8ad7cef
Compare
Signed-off-by: softworkz <[email protected]>
softworkz
force-pushed
the
submit_killerscript
branch
from
8ad7cef to
08e01d9
Compare
Collaborator
Author
|
/submit |
|
Submitted as [email protected] To fetch this version into To fetch this version to local tag |
|
On the FFmpeg mailing list, Kieran Kunhya via ffmpeg-devel wrote (reply to this): |
|
On the FFmpeg mailing list, "softworkz ." wrote (reply to this): |
|
On the FFmpeg mailing list, "softworkz ." wrote (reply to this): |
|
On the FFmpeg mailing list, Nicolas George wrote (reply to this): |
![ffmpeg-codebot[bot]](https://avatars.githubusercontent.com/in/158557?s=60&v=4){kind=small}
| *_g | ||
| \#* | ||
| .\#* | ||
| /.config |
There was a problem hiding this comment.
On the FFmpeg mailing list, Marton Balint wrote (reply to this):
On Mon, 9 Jun 2025, softworkz wrote:
> From: softworkz <[email protected]>
>
> Signed-off-by: softworkz <[email protected]>
> ---
> .gitignore | 1 +
> fftools/Makefile | 14 ++++++++++++--
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index 59c89da5e0..989c702b6c 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -32,6 +32,7 @@
> /.config
> /.version
> /ffmpeg
> +/ffmpeg-sg
Please, do not copy this from tools folder to the main build dir. The rest
of the tools are also simply kept in the tools folder, no copying is
necessary during the build process.
Thanks,
Marton
> /ffplay
> /ffprobe
> /config.asm
> diff --git a/fftools/Makefile b/fftools/Makefile
> index b3c08ae5a0..378de79665 100644
> --- a/fftools/Makefile
> +++ b/fftools/Makefile
> @@ -5,6 +5,11 @@ AVPROGS-$(CONFIG_FFPROBE) += ffprobe
> AVPROGS := $(AVPROGS-yes:%=%$(PROGSSUF)$(EXESUF))
> PROGS += $(AVPROGS)
>
> +FFMPEG_SG_SCRIPT = $(SRC_PATH)/tools/ffmpeg-sg$(if $(filter .exe,$(EXESUF)),.cmd)
> +FFMPEG_SG_TARGET = ffmpeg-sg$(EXESUF)
> +FFMPEG_SG_ENABLED = $(and $(filter $(CONFIG_FFMPEG),yes),$(or $(filter $(target_os),win32),$(if $(target_os),,yes)))
> +FFMPEG_SG_FILES = $(if $(FFMPEG_SG_ENABLED),$(FFMPEG_SG_TARGET))
> +
> AVBASENAMES = ffmpeg ffplay ffprobe
> ALLAVPROGS = $(AVBASENAMES:%=%$(PROGSSUF)$(EXESUF))
> ALLAVPROGS_G = $(AVBASENAMES:%=%$(PROGSSUF)_g$(EXESUF))
> @@ -67,7 +72,10 @@ endef
>
> $(foreach P,$(AVPROGS-yes),$(eval $(call DOFFTOOL,$(P))))
>
> -all: $(AVPROGS)
> +all: $(AVPROGS) $(FFMPEG_SG_FILES)
> +
> +$(FFMPEG_SG_TARGET): $(FFMPEG_SG_SCRIPT)
> + $(Q)$(CP) -p $(FFMPEG_SG_SCRIPT) $(FFMPEG_SG_TARGET)
>
> fftools/ffprobe.o fftools/cmdutils.o: libavutil/ffversion.h | fftools
> OUTDIRS += fftools
> @@ -85,11 +93,13 @@ install-progs-$(CONFIG_SHARED): install-libs
> install-progs: install-progs-yes $(AVPROGS)
> $(Q)mkdir -p "$(BINDIR)"
> $(INSTALL) -c -m 755 $(AVPROGS) "$(BINDIR)"
> + $(if $(FFMPEG_SG_FILES),$(INSTALL) -c -m 755 $(FFMPEG_SG_FILES) "$(BINDIR)")
>
> uninstall: uninstall-progs
>
> uninstall-progs:
> $(RM) $(addprefix "$(BINDIR)/", $(ALLAVPROGS))
> + $(if $(FFMPEG_SG_FILES),$(RM) "$(BINDIR)/$(FFMPEG_SG_FILES)")
>
> clean::
> - $(RM) $(ALLAVPROGS) $(ALLAVPROGS_G) $(CLEANSUFFIXES:%=fftools/%) $(CLEANSUFFIXES:%=fftools/graph/%) $(CLEANSUFFIXES:%=fftools/textformat/%)
> + $(RM) $(ALLAVPROGS) $(ALLAVPROGS_G) $(CLEANSUFFIXES:%=fftools/%) $(CLEANSUFFIXES:%=fftools/graph/%) $(CLEANSUFFIXES:%=fftools/textformat/%) $(FFMPEG_SG_FILES)
> --
> ffmpeg-codebot
> _______________________________________________
> ffmpeg-devel mailing list
> [email protected]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> [email protected] with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
There was a problem hiding this comment.
On the FFmpeg mailing list, "softworkz ." wrote (reply to this):
> -----Original Message-----
> From: ffmpeg-devel <[email protected]> On Behalf Of
> Marton Balint
> Sent: Mittwoch, 11. Juni 2025 21:18
> To: FFmpeg development discussions and patches <ffmpeg-
> [email protected]>
> Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include
> show-graph wrapper script in build output
>
>
>
> On Mon, 9 Jun 2025, softworkz wrote:
>
> > From: softworkz <[email protected]>
> >
> > Signed-off-by: softworkz <[email protected]>
> > ---
> > .gitignore | 1 +
> > fftools/Makefile | 14 ++++++++++++--
> > 2 files changed, 13 insertions(+), 2 deletions(-)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 59c89da5e0..989c702b6c 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -32,6 +32,7 @@
> > /.config
> > /.version
> > /ffmpeg
> > +/ffmpeg-sg
>
> Please, do not copy this from tools folder to the main build dir. The
> rest
> of the tools are also simply kept in the tools folder, no copying is
> necessary during the build process.
>
> Thanks,
> Marton
>
On important platforms like Windows, there is no "install". People are
taking/copying the build output. If it's not part of the build output,
it won't arrive at any user.
Also, for security reasons, the script requires an ffmpeg binary in the
same directory. Unless the script is in the same directory as the
ffmpeg binary, it has no value at all.
The previous patch has gone great circles because I have been subject to
false accusations and damage of reputation.
This situation is different: I have laid out my arguments and opinion,
but that's just one small voice of many and I have no intentions to go
crazy about or fight for it. No matter how this may come to a decision,
I don't want to stand in the center of it.
There's one crucial point about this patchset, though:
The purpose is to make the feature available to the masses, both
developers and users (see 'instant availability' in my earlier response
to Kieran).
If this cannot be achieved and agreed, then it would have failed its
goal but I'd still say that it was worth the attempt.
Yet, I hope you can understand when I say that anything less than this
goal, is nothing for which I will take any effort at all. The scripts
are there, they can be downloaded from my GitHub - for those who know.
Thanks, and best regards
sw
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
There was a problem hiding this comment.
On the FFmpeg mailing list, Kieran Kunhya via ffmpeg-devel wrote (reply to this):
--===============4338711860443026609==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <[email protected]>
X-Original-To: [email protected]
Delivered-To: [email protected]
Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170])
by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 48CFC687FCC
for <[email protected]>; Thu, 12 Jun 2025 00:14:35 +0300 (EEST)
Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-70e3c6b88dbso1794587b3.0
for <[email protected]>; Wed, 11 Jun 2025 14:14:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=googlemail.com; s=20230601; t=1749676473; x=1750281273; darn=ffmpeg.org;
h=content-transfer-encoding:to:subject:message-id:date:from
:in-reply-to:references:mime-version:from:to:cc:subject:date
:message-id:reply-to;
bh=dkTqc0UhjV8S1LhPSa2cTp9ArV9SPh35pPxbgYbNKE0=;
b=WDr8kx91q3BgvcGiN2VMqhzDjMvjK5G3kLS0Z2oYGYrPP4zOc0JMBtc09jEHwcyyam
1Qo31MXECjn6tDi6ZoevteBDjTa7UZpZhBkKIOhgbbXuklw8zGjOACDM7ycXtc4yc9QR
CY1KobBmw2DUoIInkNcTpXhDRLoTVIjHIfI9NfDz6kPPMGVMeLcqatRaNsEO1CQ7nSYo
eT8nbK4665a7EBoVwQC3vjLNuz7pf/7AqKfvp5tKNllXtCjvYG6/ddRpXhIHDPUoFbVu
5Aam3i10Yph/zxlgENdli7aluI9lQAJysEiHHVw6Bgj4D2sl1qNePhbKfSiMXZ4JZPMo
s40Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1749676473; x=1750281273;
h=content-transfer-encoding:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=dkTqc0UhjV8S1LhPSa2cTp9ArV9SPh35pPxbgYbNKE0=;
b=OgEpK056MZTBc+J0EH1B6xvx1acF5XMphye4hXB0b/nNyIxdyvQjYzMEYuVEX+0Gfg
WumzAUhchiOqjn9IVDYv48QuBy83uz7FLJTWUP007bi3fW3Xkf7m77ye81kt4QUsO06q
y84o5by/IfpV3qwO0Cn47zYmz3mCLvaRvFNdECCHA7dRvCDZA1lMtirOE7CQTQkNzfHf
TCLenQQ9KEh0C+eAyt8td7+Ql3TD9B1kYBClA/gamLcwus1uje9HdwE9V1wYFFk1VxNe
tv0fZXAVtQZwQUMlHWp4BIJscSvwXraQH0Yrdpl0fm6UjlnbwzUUHv3Br6qm0JqTSOOL
yrPA==
X-Gm-Message-State: AOJu0YxLwZf2QJnkgL+MIBH4VQJjt3QyrzgErVmJAvbkzK9o+rcdbXdm
R10fKpsNIyotUv48/VsncmqJjZ4W/eoGJP5Wi0naEnaEgcj/9vBnd9+batW9nE6urj9dV0zwr5b
E+Q/Uwk0b2SyBsjnRHadWxjvUUIGyCrWggQ==
X-Gm-Gg: ASbGncvTZOuwayDh8KdiKI0S0mZgVT0RIeXBJijTKbwyUJNF6CTCMZEc/QKjJz4oQiX
NS0Sjgf43yzUgqyu3FKRu1KpVHKJScZVlHoKob1AeJVWUpvP2ic4R+kbrR8131szY/NwohJbDYF
LqViu11J8236+WmH7SsUfnpHrMf+1sttpsY72j+tKKePY=
X-Google-Smtp-Source: AGHT+IHggUFhj9PMMWpRPdKapBLPhM3MiB6UjOy7+hnCfcWNl7BrPYsjO8VWaPDyLpWZS3c3t+BZ6MYWc0DM7vG1S68=
X-Received: by 2002:a05:690c:3584:b0:70c:a57c:94ba with SMTP id
00721157ae682-71140ab7fe8mr78058997b3.17.1749676472516; Wed, 11 Jun 2025
14:14:32 -0700 (PDT)
MIME-Version: 1.0
References: <[email protected]>
<08e01d9ad96b56dac6f0f1f0912e0aa94f80e8d0.1749497028.git.ffmpegagent@gmail.com>
<[email protected]> <DM8P223MB036554BDCE004848A84C5E45BA75A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
In-Reply-To: <DM8P223MB036554BDCE004848A84C5E45BA75A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
From: Kieran Kunhya <[email protected]>
Date: Wed, 11 Jun 2025 22:14:20 +0100
X-Gm-Features: AX0GCFtNNE9dkKU3so-3NNx739YQJCg2909lF9uJZht9kvE-YI7ZeepbOrJUVrE
Message-ID: <CABGuwEm72Ynf=anVta4rj0pOPThHeM0aweAbYVTBuvLsQSbJ4Q@mail.gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include show-graph
wrapper script in build output
To: FFmpeg development discussions and patches <[email protected]>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Wed, Jun 11, 2025 at 9:58=E2=80=AFPM softworkz .
<[email protected]> wrote:
>
>
>
> > -----Original Message-----
> > From: ffmpeg-devel <[email protected]> On Behalf Of
> > Marton Balint
> > Sent: Mittwoch, 11. Juni 2025 21:18
> > To: FFmpeg development discussions and patches <ffmpeg-
> > [email protected]>
> > Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include
> > show-graph wrapper script in build output
> >
> >
> >
> > On Mon, 9 Jun 2025, softworkz wrote:
> >
> > > From: softworkz <[email protected]>
> > >
> > > Signed-off-by: softworkz <[email protected]>
> > > ---
> > > .gitignore | 1 +
> > > fftools/Makefile | 14 ++++++++++++--
> > > 2 files changed, 13 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/.gitignore b/.gitignore
> > > index 59c89da5e0..989c702b6c 100644
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > @@ -32,6 +32,7 @@
> > > /.config
> > > /.version
> > > /ffmpeg
> > > +/ffmpeg-sg
> >
> > Please, do not copy this from tools folder to the main build dir. The
> > rest
> > of the tools are also simply kept in the tools folder, no copying is
> > necessary during the build process.
> >
> > Thanks,
> > Marton
> >
>
> On important platforms like Windows, there is no "install". People are
> taking/copying the build output. If it's not part of the build output,
> it won't arrive at any user.
On windows and other desktops you just click the file name and a browser op=
ens.
Does this really need a script just to do that?
Should we have a script to run ffplay after a user has encoded a file as we=
ll?
Kieran
--===============4338711860443026609==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
--===============4338711860443026609==--
There was a problem hiding this comment.
On the FFmpeg mailing list, "softworkz ." wrote (reply to this):
> -----Original Message-----
> From: Kieran Kunhya <[email protected]>
> Sent: Mittwoch, 11. Juni 2025 23:14
> To: FFmpeg development discussions and patches <ffmpeg-
> [email protected]>
> Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include
> show-graph wrapper script in build output
>
> On Wed, Jun 11, 2025 at 9:58 PM softworkz .
> <[email protected]> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: ffmpeg-devel <[email protected]> On Behalf Of
> > > Marton Balint
> > > Sent: Mittwoch, 11. Juni 2025 21:18
> > > To: FFmpeg development discussions and patches <ffmpeg-
> > > [email protected]>
> > > Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include
> > > show-graph wrapper script in build output
> > >
> > >
> > >
> > > On Mon, 9 Jun 2025, softworkz wrote:
> > >
> > > > From: softworkz <[email protected]>
> > > >
> > > > Signed-off-by: softworkz <[email protected]>
> > > > ---
> > > > .gitignore | 1 +
> > > > fftools/Makefile | 14 ++++++++++++--
> > > > 2 files changed, 13 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/.gitignore b/.gitignore
> > > > index 59c89da5e0..989c702b6c 100644
> > > > --- a/.gitignore
> > > > +++ b/.gitignore
> > > > @@ -32,6 +32,7 @@
> > > > /.config
> > > > /.version
> > > > /ffmpeg
> > > > +/ffmpeg-sg
> > >
> > > Please, do not copy this from tools folder to the main build dir.
> The
> > > rest
> > > of the tools are also simply kept in the tools folder, no copying
> is
> > > necessary during the build process.
> > >
> > > Thanks,
> > > Marton
> > >
> >
> > On important platforms like Windows, there is no "install". People
> are
> > taking/copying the build output. If it's not part of the build
> output,
> > it won't arrive at any user.
>
> On windows and other desktops you just click the file name and a
> browser opens.
> Does this really need a script just to do that?
Hi Kieran,
I believe that when you would try out both ways yourself and compare,
you wouldn't ask the question. Or - if you wish, I can create a short
screen capture to illustrate?
Best regards
sw
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
There was a problem hiding this comment.
On the FFmpeg mailing list, "softworkz ." wrote (reply to this):
> -----Original Message-----
> From: Kieran Kunhya <[email protected]>
> Sent: Mittwoch, 11. Juni 2025 23:14
> To: FFmpeg development discussions and patches <ffmpeg-
> [email protected]>
> Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include
> show-graph wrapper script in build output
>
> On Wed, Jun 11, 2025 at 9:58 PM softworkz .
> <[email protected]> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: ffmpeg-devel <[email protected]> On Behalf Of
> > > Marton Balint
> > > Sent: Mittwoch, 11. Juni 2025 21:18
> > > To: FFmpeg development discussions and patches <ffmpeg-
> > > [email protected]>
> > > Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include
> > > show-graph wrapper script in build output
> > >
> > >
> > >
> > > On Mon, 9 Jun 2025, softworkz wrote:
> > >
> > > > From: softworkz <[email protected]>
> > > >
> > > > Signed-off-by: softworkz <[email protected]>
> > > > ---
> > > > .gitignore | 1 +
> > > > fftools/Makefile | 14 ++++++++++++--
> > > > 2 files changed, 13 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/.gitignore b/.gitignore
> > > > index 59c89da5e0..989c702b6c 100644
> > > > --- a/.gitignore
> > > > +++ b/.gitignore
> > > > @@ -32,6 +32,7 @@
> > > > /.config
> > > > /.version
> > > > /ffmpeg
> > > > +/ffmpeg-sg
> > >
> Should we have a script to run ffplay after a user has encoded a file
> as well?
>
> Kieran
-----------------
The difference to this - as far as I'm seeing it - is that that the
execution graph display is of a very different nature: It is (at least
logically) not an output of FFmpeg like a produced media file. It
rather provides insights into FFmpeg's own operations - to the operator
and not to the client/consumer of the output.
It could even be seen as a kind of (passive) UI - for monitoring and
diagnosis, which is something very different from launching a generated
video file.
And regarding the latter - don't we have those output devices, where
you just need to add a few letters to the command line to "launch"
a video window that is showing the output?
Best regards,
sw
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
There was a problem hiding this comment.
On the FFmpeg mailing list, Nicolas George wrote (reply to this):
softworkz . (HE12025-06-11):
> On important platforms like Windows, there is no "install". People are
> taking/copying the build output. If it's not part of the build output,
> it won't arrive at any user.
Oh, we did not think of that in the past 20 years, and we could not
consider it to decide the policy. Thank Cthulhu you came!
> Also, for security reasons, the script requires an ffmpeg binary in the
> same directory. Unless the script is in the same directory as the
> ffmpeg binary, it has no value at all.
Then you need to program your script better.
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
There was a problem hiding this comment.
On the FFmpeg mailing list, "softworkz ." wrote (reply to this):
> -----Original Message-----
> From: ffmpeg-devel <[email protected]> On Behalf Of
> Nicolas George
> Sent: Donnerstag, 12. Juni 2025 09:41
> To: FFmpeg development discussions and patches <ffmpeg-
> [email protected]>
> Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include
> show-graph wrapper script in build output
>
> softworkz . (HE12025-06-11):
> > On important platforms like Windows, there is no "install".
> People are
> > taking/copying the build output. If it's not part of the build
> output,
> > it won't arrive at any user.
>
> Oh, we did not think of that in the past 20 years, and we could not
> consider it to decide the policy. Thank Cthulhu you came!
Absolutely correct. It wasn't thought about in the past 20 years.
That's why nobody (besides few) knows about or uses things like
graph2dot.
> > Also, for security reasons, the script requires an ffmpeg binary
> in the
> > same directory. Unless the script is in the same directory as the
> > ffmpeg binary, it has no value at all.
>
> Then you need to program your script better.
"better" would be worse, so that's not gonna happen.
The way how the feature is meant to work is laid out clearly:
"Add '-sg' to the command line to get the execution graph shown
in the browser"
If you want something else, you can write your own script.
Whether the feature should be included or not, might be best left
up for decision by the TC, I'm just giving it some time for
comments first, even though we know that proponents will be
quite and opponents loud, as always.
Best regards
sw
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
There was a problem hiding this comment.
On the FFmpeg mailing list, Nicolas George wrote (reply to this):
softworkz . (HE12025-06-12):
> "better" would be worse, so that's not gonna happen.
Then your patch is not going to happen.
> The way how the feature is meant to work is laid out clearly:
If you cannot find a way to do this without copying the script, you need
to give up and try something easier.
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
There was a problem hiding this comment.
On the FFmpeg mailing list, "softworkz ." wrote (reply to this):
> -----Original Message-----
> From: ffmpeg-devel <[email protected]> On Behalf Of
> Nicolas George
> Sent: Donnerstag, 12. Juni 2025 21:07
> To: FFmpeg development discussions and patches <ffmpeg-
> [email protected]>
> Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include
> show-graph wrapper script in build output
>
> softworkz . (HE12025-06-12):
> > "better" would be worse, so that's not gonna happen.
>
> Then your patch is not going to happen.
>
> > The way how the feature is meant to work is laid out clearly:
>
> If you cannot find a way to do this without copying the script, you
> need
> to give up and try something easier.
>
> --
> Nicolas George
Take your meds and try an AI chat if you want to annoy somebody.
sw
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "killer feature" returns!
Different approach - same procedure:
but
SG = Show Graph
Documentation and examples can be found here:
https://github.com/softworkz/ffmpeg_output_apis/wiki