Skip to content

Comments

fix Encoding::UndefinedConversionError#19

Open
S-YOU wants to merge 1 commit intofguillen:masterfrom
S-YOU:S-YOU-patch-1
Open

fix Encoding::UndefinedConversionError#19
S-YOU wants to merge 1 commit intofguillen:masterfrom
S-YOU:S-YOU-patch-1

Conversation

@S-YOU
Copy link

@S-YOU S-YOU commented Jan 5, 2018

If the source code or comments has unicode characters, (and may be in some ruby versions),
rcov_result.encoding results in #Encoding:ASCII-8BIT, but OS encoding is UTF-8, and
conversion happens before file write, and which in turn results in error.

~/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/simplecov-rcov-0.2.3/lib/simplecov-rcov.rb:53:in `write': "\xE4" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)

@vincentjiang
Copy link

@S-YOU
I meet this problem too.

gems/simplecov-rcov-0.2.3/lib/simplecov-rcov.rb:52:in `write': "\xE8" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)

@brightball
Copy link

Same problem.

@vincentjiang
Copy link

@fguillen Please review and fix the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants