Open
Conversation
…ipt.js into a separate blinken.js. This is necessary to be able to reuse the blinkenlight js methods from both the main page and the blinkmoji.
mbalasz
commented
Nov 4, 2021
| socket.on("chat message", (msg) => { | ||
| console.log("Received message: " + msg); | ||
| const user = findUser(socket.id); | ||
| printEmoji(String.fromCodePoint(msg.codePointAt(0)), user.room); |
Author
There was a problem hiding this comment.
Found a bug :)
user can be undefined. Leaving a comment for myself to fix it asap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Fede,
As discussed I gave it a shot to integrate the Blinkmoji web app with your repo.
Summary of changes
script.jsto extract common functionality for just controlling the blinkenlights to a separate script calledblinken.jsRequirements on the server side
As specified on my original repo page (https://github.com/mbalasz/blinkmoji#requirements) the server hosting the web app needs to have ImageMagick installed. It also needs the
Noto Color Emojifont.Local testing
npm installto download some extra node modulespackage.jsonof the module that provides emoji icons. So locally I recommend you add those linesnode server.jslocalhost:3000/blinkmojiNew Branch?
I'd be happy to merge this into a separate branch as opposed to
mainto start with. However, I think you'd need to first create such branch.I'm happy to chat more about this PR before moving forward. Just wanted to have some draft ready.