chore(deps): upgrade chokidar to v4#407
Closed
stianjensen wants to merge 1 commit intofi3ework:mainfrom
Closed
Conversation
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Unsure if/how the snapshot changes here are related to the Chokidar upgrade 🤔 |
|
Any updates @fi3ework ? |
danielroe
changed the title
chokidar to v4
Collaborator
|
The snapshot changes are indicate that the watcher isn't picking up on some changes - likely we need to update more than just the version of |
Contributor
Author
|
Ah, right – I overlooked the fact that globs are used in some of the watcher.add calls after initially creating the watcher! |
https://github.com/paulmillr/chokidar/releases/tag/4.0.0 The most important breaking change is that it removes support for globs, which'll need a new solution on top. Then it updates minimum required node version to 14.x (same as already used here).
stianjensen
force-pushed
the
chokidar-4
branch
from
bd08ecf to
8e56af2
Compare
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/paulmillr/chokidar/releases/tag/4.0.0
The only breaking changes are that it removes support for globs (not used here), and ups minimum required node version to 14.x (same as already used here).