Skip to content

Issue #1834 - Image attachments: capture GPS coordinates from Exif data #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
homedirectory wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

Issue #1834 - Image attachments: capture GPS coordinates from Exif data #2297

homedirectory wants to merge 18 commits into from

Conversation

@homedirectory
Copy link
Member

@homedirectory homedirectory commented Jul 23, 2024

Resolve #1834

@homedirectory
#1834 Correct a typo
62c5b03
@homedirectory
#1834 Introduce utilities for extracting GPS coordinates from images …
9bad575 
…using Apache Commons Imaging
@homedirectory
#1834 Enhance Attachment with properties for latitude and longitude
2093e46
@homedirectory
#1834 Extract GPS data from attachments during an upload
1ad9665
@homedirectory
#1834 Test GPS coordinates capturing during Attachment uploading
71fa943
@homedirectory
#1834 Check file format before attempting to process Exif data
80497ff 
This avoids IllegalArgumentException if given a file that is not an
image
@homedirectory
#1834 Test GPS coordinates capturing for a non-image file
e4823b6
@homedirectory
#1834 Replace String concatenation of File.separator with Path.of
dde5156
@homedirectory
#1834 Add validators for latitude and longitude of Attachment
6fb84a0
@homedirectory
#1834 Test validation of latitude and longitude of Attachment
60798d4
@homedirectory
#1834 Ignore invalid GPS coordinates during Attachment uploading
e9697db
@homedirectory
#1834 Test uploading of Attachment with invalid GPS coordinates
1bcdc68
@homedirectory
#1834 Ignore GPS coordinates if errors occur during processing of Att…
a02e925 
…achment

We don't want to fail the whole upload if GPS coordinates could not be
extracted for some reason. Instead, simply ignore the coordinates and
log the error for future analysis.
@homedirectory
#1834 Introduce a test util for asserting file existence and readability
4b7065a
@homedirectory
#1834 Enhance Attachment companion with a method for accessing the Pa…
9fa8fae 
…th of an Attachment
@homedirectory
#1834 Harden tests with assertions about readability of uploaded atta…
4415524 
…chments
@homedirectory
#1834 Shorten titles of latitude and longitude properties of Attachment
3029585
@homedirectory
#1834 Make latitude and longitude of Attachment read-only
6718748 
Since this information is extracted from metadata of a file, users are
not supposed to be able to modify it.
@homedirectory homedirectory requested a review from 01es July 23, 2024 09:03
@01es 01es marked this pull request as draft January 31, 2025 02:06
@01es
Copy link
Member

01es commented Jan 31, 2025

@homedirectory Converted to draft pending additional changes to be discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@01es 01es Awaiting requested review from 01es

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Image attachments: capture GPS coordinates from Exif data

3 participants

@homedirectory @01es