Skip to content

Conversation

@oleh-maikovych
Copy link
Member

@oleh-maikovych oleh-maikovych commented Jan 30, 2026

Resolve #2567

To be completed by the pull request creator

This section should be completed with reference to section Preparing PR of the Code and PR reviews wiki page.

  • Create the pull request as a draft by tapping the dropdown arrow on the 'Create pull request' button under the pull request description (below the text box where this description is being edited) and changing the default Create pull request to Draft pull request.
    Or, if the pull request has already been created, convert it to draft by tapping the "Convert to draft" link beneath the "Reviewers" section.

  • A self-review of all changes has been completed, and the changes are in sync with the issue requirements.

  • Changes to the requirements have been reflected in the issue description.

  • Any "leftovers" such as sysouts, printing of stack traces, and any other "temporary" code, have been removed.

  • Minor refactorings, such as renamings, extraction of constants, etc., have been addressed.

  • Developer documentation (e.g., comments, Javadoc), have been provided where required.

  • New Java tests have been written or existing tests adjusted, if required, to cover the new functionality.

  • All existing and new Java tests pass successfully by running them with Maven.

  • New Web tests have been written or existing tests adjusted, if required, to cover the new functionality.

  • All existing and new Web tests pass successfully.

  • Established security practices have been followed, including the existence and attribution of security tokens.

  • Changes have been inspected for possible NPE situations, and the changes are sufficiently defensive.

  • The correct base branch has been selected for these changes to be merged into.

  • The latest changes from the base branch have already been merged into this feature branch (and tested).

  • Added a change overview to the issue description or as a wiki page, referenced in the issue description.
    Some issues might be very descriptive and serve in place of a wiki page.
    In such cases consider adding label Wiki like to the issue.

  • Changes subject to performance considerations have been evaluated, and tested against production-size data if applicable.

  • This pull request does contain significant changes, the section "Significant changes" below is completed and at least one Senior Software Engineer with the relevant area of expertise has been selected as reviewer.

  • The In progress label has been removed from the issue.

  • The Pull request label has been added to the issue.

  • The pull request has been made ready for review by tapping the "Ready for review" button below the list of commits on the pull request page.

Additional details

  • The tg-app-config element is initialized with values from the window.TG_APP object. If TG_APP is not initialized, default values are used. Please consider whether these default values make sense. Note that web unit tests do not load the TG_APP object from the server; therefore, default values in the tg-app-config element are useful to avoid enhancing every web unit test with a separate configuration object.

  • Carefully review the index.html file, as it is responsible for fetching the TG_APP object from the server and enhancing the DOM with tg-app-template and tg-qr-code-scanner after application resources are loaded.

  • Review the tg-app-menu element. The changes made to this element may impact the mobile application view. The update modifies the structure of the main menu top panel and removes display: content from the inner container. This style now appears to be redundant.

  • Note that most configuration options are managed by the IWebUiConfig interface. Only the currencySymbol option remains in the IApplicationSettings interface, as it may be used in companion objects in the future.

Significant changes

This pull request changes the way the tg-app-config element is initialised. This element is used by a number of other elements; therefore, the implications of these changes are significant.

This pull request contains significant changes as defined in the wiki page.

Details are as follows:

To be completed by the pull request reviewer

This section should be completed with reference to section Performing PR review of the Code and PR reviews wiki page.

  • The In progress label has been added to the pull request in GitHub.

  • The issue requirements have been read and understood (along with any relevant emails and/or Slack messages).

  • The correct base branch is specified, and that base branch is up-to-date in the local source.

  • The issue branch has been checked out locally, and had the base branch merged into it.

  • All automated tests pass successfully.

  • Ensure the implementation satisfies the functional requirements.

  • Ensure that code changes are secure and align with the established coding practices, including code formatting and naming conventions.

  • Ensure that code changes are documented and covered with automated tests as applicable.

  • Ensure that code changes are well-suited for informal reasoning.

  • Ensure that changes are documented for the end-user (a software engineer in the case of TG, or an application user in the case of TG-based applications).

  • If there are significant changes (described above), special attention has been paid to them.
    Marked the task items in section "Significant changes" as completed to indicate that corresponding changes have been reviewed, improved if necessary, and approved.

  • The issue or issues addressed by the pull request are associated with the relevant release milestone.

To be completed by the pull request reviewer once the changes have been reviewed and accepted

  • The changes have been merged into the base branch (unless there is a specific request not to do so, e.g., they are to be released to SIT).

  • The issue branch has been deleted (unless the changes have not been merged - see above, or there is a specific request not to do so).

  • The In progress label has been removed from the pull request.

  • The Pull request label has been removed from the issue.

…ation configuration entity instead of menu.
…ss with time zone related properties to make dynamic instead of dependent from reseource generation process.
…pp config element. Also enhnaced IMenuRetriever. Renamed it into iWebAppConfigProvider as it will be used as aggregation for other app config parameters.
…nerated properties from tg-app-config element.
…nfig to make application configuration properties dynamic.
…app-loader so that it makes import of app resource dynamic and dependent from app-config.
…lcanization process unchnaged. Simplified tg-app-config.
…l file which were generated into that file.
@oleh-maikovych oleh-maikovych marked this pull request as ready for review February 3, 2026 14:36
…loading. Also this message indicates what configuration was used to run application (default or previously saved).
… fallback to defautl. Enhanced error messages for different types of error.
… configuration loading error with fallback to saved configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Application-specific parameters: dynamic loading

1 participant