refine the expect for method

Author: janishar

tests/auth/apikey/index.test.ts

@@ -14,7 +14,7 @@ describe('apikey validation', () => {
 	it('Should response with 400 if api-key header is not passed', async () => {
 		const response = await request.get(endpoint);
 		expect(response.status).toBe(400);
-		expect(mockFindApiKey).toBeCalledTimes(0);
+		expect(mockFindApiKey).not.toBeCalled();
 	});
 
 	it('Should response with 403 if wrong api-key header is passed', async () => {

tests/auth/authentication/index.test.ts

@@ -23,15 +23,15 @@ describe('authentication validation', () => {
 			.set('x-user-id', USER_ID.toHexString());
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/x-access-token/);
-		expect(mockUserFindById).toBeCalledTimes(0);
+		expect(mockUserFindById).not.toBeCalled();
 	});
 
 	it('Should response with 400 if x-user-id header is not passed', async () => {
 		const response = await addHeaders(request.get(endpoint))
 			.set('x-access-token', ACCESS_TOKEN);
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/x-user-id/);
-		expect(mockUserFindById).toBeCalledTimes(0);
+		expect(mockUserFindById).not.toBeCalled();
 	});
 
 	it('Should response with 400 if x-user-id header is not mongoose id', async () => {
@@ -40,7 +40,7 @@ describe('authentication validation', () => {
 			.set('x-user-id', '123');
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/x-user-id/);
-		expect(mockUserFindById).toBeCalledTimes(0);
+		expect(mockUserFindById).not.toBeCalled();
 	});
 
 	it('Should response with 401 if wrong x-user-id header is provided', async () => {

tests/routes/v1/login/index.test.ts

@@ -23,9 +23,9 @@ describe('Login Route', () => {
 	it('Should throw error when empty body is sent', async () => {
 		const response = await addHeaders(request.post(endpoint));
 		expect(response.status).toBe(400);
-		expect(mockUserFindByEmail).toBeCalledTimes(0);
-		expect(mockKeystoreCreate).toBeCalledTimes(0);
-		expect(createTokensSpy).toBeCalledTimes(0);
+		expect(mockUserFindByEmail).not.toBeCalled();
+		expect(mockKeystoreCreate).not.toBeCalled();
+		expect(createTokensSpy).not.toBeCalled();
 	});
 
 	it('Should throw error when email is only sent', async () => {
@@ -34,9 +34,9 @@ describe('Login Route', () => {
 		);
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/password/);
-		expect(mockUserFindByEmail).toBeCalledTimes(0);
-		expect(mockKeystoreCreate).toBeCalledTimes(0);
-		expect(createTokensSpy).toBeCalledTimes(0);
+		expect(mockUserFindByEmail).not.toBeCalled();
+		expect(mockKeystoreCreate).not.toBeCalled();
+		expect(createTokensSpy).not.toBeCalled();
 	});
 
 	it('Should throw error when password is only sent', async () => {
@@ -45,9 +45,9 @@ describe('Login Route', () => {
 		);
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/email/);
-		expect(mockUserFindByEmail).toBeCalledTimes(0);
-		expect(mockKeystoreCreate).toBeCalledTimes(0);
-		expect(createTokensSpy).toBeCalledTimes(0);
+		expect(mockUserFindByEmail).not.toBeCalled();
+		expect(mockKeystoreCreate).not.toBeCalled();
+		expect(createTokensSpy).not.toBeCalled();
 	});
 
 	it('Should throw error when email is not valid format', async () => {
@@ -56,9 +56,9 @@ describe('Login Route', () => {
 		);
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/valid email/);
-		expect(mockUserFindByEmail).toBeCalledTimes(0);
-		expect(mockKeystoreCreate).toBeCalledTimes(0);
-		expect(createTokensSpy).toBeCalledTimes(0);
+		expect(mockUserFindByEmail).not.toBeCalled();
+		expect(mockKeystoreCreate).not.toBeCalled();
+		expect(createTokensSpy).not.toBeCalled();
 	});
 
 	it('Should throw error when password is not valid format', async () => {
@@ -70,9 +70,9 @@ describe('Login Route', () => {
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/password length/);
 		expect(response.body.message).toMatch(/6 char/);
-		expect(mockUserFindByEmail).toBeCalledTimes(0);
-		expect(mockKeystoreCreate).toBeCalledTimes(0);
-		expect(createTokensSpy).toBeCalledTimes(0);
+		expect(mockUserFindByEmail).not.toBeCalled();
+		expect(mockKeystoreCreate).not.toBeCalled();
+		expect(createTokensSpy).not.toBeCalled();
 	});
 
 	it('Should throw error when user not registered for email', async () => {
@@ -84,8 +84,8 @@ describe('Login Route', () => {
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/not registered/);
 		expect(mockUserFindByEmail).toBeCalledTimes(1);
-		expect(mockKeystoreCreate).toBeCalledTimes(0);
-		expect(createTokensSpy).toBeCalledTimes(0);
+		expect(mockKeystoreCreate).not.toBeCalled();
+		expect(createTokensSpy).not.toBeCalled();
 	});
 
 	it('Should throw error for wrong password', async () => {
@@ -97,8 +97,8 @@ describe('Login Route', () => {
 		expect(response.status).toBe(401);
 		expect(response.body.message).toMatch(/authentication failure/i);
 		expect(mockUserFindByEmail).toBeCalledTimes(1);
-		expect(mockKeystoreCreate).toBeCalledTimes(0);
-		expect(createTokensSpy).toBeCalledTimes(0);
+		expect(mockKeystoreCreate).not.toBeCalled();
+		expect(createTokensSpy).not.toBeCalled();
 	});
 
 	it('Should send success response for correct credentials', async () => {